Run ./wpt test-jobs --all to see if all tests pass
#17217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
force-pushed
the
foolip/all-test-jobs
branch
from
d54f6a7
to
a71f9e4
Compare
|
@LukeZielinski I was attempting in 143c349 to mark a failure as expected, but then the failure shifted somewhere else. This is very reminiscent of something you were telling me about debugging these tests, was it state in ChromeDriver leaking between them? Were you able to get to the bottom of that? This job isn't blocking, but it will be failing on all PRs which trigger the tests. Should we just disable them? |
foolip
force-pushed
the
foolip/all-test-jobs
branch
from
143c349
to
67e2a5d
Compare
foolip
force-pushed
the
foolip/all-test-jobs
branch
2 times, most recently
from
fa1d549
to
c32f42f
Compare
|
Possibly, but they landed longer ago. Will have to bisect I guess... |
|
Yeah, it's the issues @Ms2ger linked to. I'd noticed this last week just before heading off and never got around to filing a bug for it. :/ |
foolip
force-pushed
the
foolip/all-test-jobs
branch
from
c32f42f
to
96082fa
Compare
|
Fixed in #18819. I'll close this PR and open a new one so that y'all don't have to be notified when I keep rebasing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.