Add tests for proposed WebDriver Shadow DOM support #27132
Conversation
wpt-pr-bot
requested review from
andreastt,
AutomatedTester,
mjzffr,
shs96c and
whimboo
There was a problem hiding this comment.
Thanks @jimevans for taking a stab on it. I have a couple of comments that I added inline. I would appreciate to have good test coverage for scenarios we are already aware of for other commands. I hope that this will be fine with you.
Doing this to avoid potential naming convention of `test_` prefix in pytest. Also fix linting error
Includes adding user prompt tests
| @@ -0,0 +1,71 @@ | |||
| @pytest.fixture | |||
| def get_shadow_page(inline, shadow_content): | |||
| return inline(""" | |||
There was a problem hiding this comment.
I actually wonder how this can work with the current implementation. What you return here is a string as produced by inline(). In the tests you call get_shadow_page(...), which has to fail on a string.
So what you want is to return an inner function; the same as what we do for most of the global fixtures. And only the inner method has the shadow_content argument.
This also applies to the other commands.
There was a problem hiding this comment.
Acknowledged. Will work on this.
There was a problem hiding this comment.
Took a stab at this in c9921ba. I've probably botched it, so do feel free to re-review.
The tests within this PR correspond to the changes proposed by the PR to the WebDriver Specification for supporting Shadow DOM