Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for proposed WebDriver Shadow DOM support #27132
Add tests for proposed WebDriver Shadow DOM support #27132
Changes from 12 commits
4fcd1b7
477401e
768ad5c
c4e6a2c
94b8624
e246de3
694cc74
3855813
5a99dfc
9e70d8f
5720604
5d3b4c5
d74e42a
c9921ba
6ca0c4f
45f8649
1cf10f0
8ef520e
edd30ab
044d4e1
55e34fe
ab9cf01
fb8ab3c
eda55bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually wonder how this can work with the current implementation. What you return here is a string as produced by
inline()
. In the tests you callget_shadow_page(...)
, which has to fail on a string.So what you want is to return an inner function; the same as what we do for most of the global fixtures. And only the inner method has the
shadow_content
argument.This also applies to the other commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acknowledged. Will work on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a stab at this in c9921ba. I've probably botched it, so do feel free to re-review.