Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: Consume user activation for window.open (multi-global test) #49138

Merged
merged 5 commits into from
Nov 20, 2024
Merged

HTML: Consume user activation for window.open (multi-global test) #49138

merged 5 commits into from
Nov 20, 2024

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Nov 13, 2024 •
edited
Loading

@zcorpan
Copy link
Member Author

zcorpan commented Nov 13, 2024

Test results:

https://wpt.fyi/results/html/browsers/windows/consume-user-activation?label=pr_head&max-count=1&pr=49138

Only Chromium currently passes the single-global test. No browser passes the multi-global test. What happens in Chromium there?

cc @EdgarChen @domenic

@zcorpan zcorpan mentioned this pull request Nov 13, 2024
Merged
5 tasks
@domenic
Copy link
Member

domenic commented Nov 15, 2024 •
edited
Loading

By code inspection, Chromium seems to check user activation on the relevant window, not the entry. I'm having a hard time tracing the code through the various indirections into the windowing system, but I think this line is also referring to the relevant window.

EdgarChen
EdgarChen approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@EdgarChen EdgarChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good to me.

@zcorpan zcorpan merged commit 5ec8ba6 into master Nov 20, 2024
20 checks passed
@zcorpan zcorpan deleted the zcorpan/window-open-consume-user-activation-multi-global branch November 20, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdgarChen EdgarChen EdgarChen approved these changes

@annevk annevk Awaiting requested review from annevk

@domenic domenic Awaiting requested review from domenic

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

Assignees

@jgraham jgraham

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zcorpan @domenic @EdgarChen @jgraham @wpt-pr-bot