Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add media capture depth dictionary test #7335

Merged
merged 3 commits into from
Jan 3, 2019
Merged

Add media capture depth dictionary test #7335

merged 3 commits into from
Jan 3, 2019

Conversation

xiuqijix
Copy link
Contributor

@xiuqijix xiuqijix commented Sep 13, 2017 •
edited by wpt-pr-bot
Loading

No description provided.

@wpt-pr-bot
Copy link
Collaborator

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@ghost
Copy link

ghost commented Sep 13, 2017 •
edited by ghost
Loading

Build PASSED

Started: 2017-10-12 02:40:32
Finished: 2017-10-12 02:47:21

View more information about this build on:

@foolip
Copy link
Member

foolip commented Oct 5, 2017

Hi @kaixinjxq! I guess you reasonably expected that if you submit a PR someone will eventually come and take a look. Unfortunately that's not quite the case, especially when the status:needs-owners gets added you'll have to go hunting for someone to review.

Who would be a good reviewer for this and #7457?

@xiuqijix
Copy link
Contributor Author

@huningxin, @astojilj are you happy to be the owner to help review depth tests?

@xiuqijix
Copy link
Contributor Author

This PR is blocked on the required "Travis CI - Pull Request" check after #14499. In order to trigger it, I will close and reopen this PR.

@xiuqijix xiuqijix closed this Dec 21, 2018
@xiuqijix xiuqijix reopened this Dec 21, 2018
@astojilj
Copy link

@kainino0x thanks. I don't know how I missed this.
LGTM

@kainino0x
Copy link
Contributor

Wrong @? :)

foolip
foolip reviewed Dec 21, 2018
View reviewed changes
mediacapture-depth/OWNERS Outdated
@@ -0,0 +1,2 @@
@huningxin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this a META.yml file instead?

@xiuqijix xiuqijix force-pushed the mediacapture-depth_dictionary branch from e28177c to e2697fd Compare December 24, 2018 02:28
Honry
Honry approved these changes Dec 24, 2018
View reviewed changes
Copy link
Contributor

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think most tests could be covered by idlharness.js if we have this feature #9106 implemented. :)

@xiuqijix xiuqijix force-pushed the mediacapture-depth_dictionary branch from 05f77fd to 3c55ab1 Compare January 3, 2019 06:14
@wpt-pr-bot wpt-pr-bot requested a review from Honry January 3, 2019 06:14
@Honry Honry merged commit fc8ca52 into web-platform-tests:master Jan 3, 2019
@xiuqijix xiuqijix deleted the mediacapture-depth_dictionary branch January 3, 2019 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip left review comments

@anssiko anssiko Awaiting requested review from anssiko

@robman robman Awaiting requested review from robman

@Honry Honry Awaiting requested review from Honry

Assignees

@robman robman

Labels
mediacapture-depth status:needs-reviewers wg-dap wg-das wg-webrtc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xiuqijix @wpt-pr-bot @foolip @astojilj @kainino0x @Honry @robman