Test Depth Stream with MediaStream interface #7457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
Build PASSEDStarted: 2017-09-25 02:43:56 View more information about this build on: |
xiuqijix
force-pushed
the
streams-to-depth
branch
from
c8508cc to
29f9ea5
Compare
Reuse tests from https://github.com/w3c/web-platform-tests/blob/master/mediacapture-streams/ to test Depth Stream with some optimizations: - Move proper tests into one file to reduce testing effort - Rewrite most tests with `promise_test`
|
@kaixinjxq, can you add an OWNERS file given that this is a new directory? Add whoever you think would be a good review and see if they complain :) |
|
This PR is blocked on the required "Travis CI - Pull Request" check after #14499. In order to trigger it, I will close and reopen this PR. |
|
We retired this spec and deprecated the implementation. Anyway, thanks for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse tests from https://github.com/w3c/web-platform-tests/blob/master/mediacapture-streams/
to test Depth Stream with some optimizations:
promise_test