Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"undefined" resolves as an error #2

Closed
obscuren opened this issue Oct 31, 2014 · 1 comment
Closed

"undefined" resolves as an error #2

obscuren opened this issue Oct 31, 2014 · 1 comment

Comments

@obscuren
Copy link
Contributor

This shouldn't result in an error. It's perfectly fine to return "undefined" from eth.transaction(num, i) for example

@debris
Copy link
Contributor

debris commented Nov 21, 2014

this bug is no longer present

greg-flexidao added a commit to greg-flexidao/web3.js that referenced this issue Sep 13, 2018
Not fulfilling the promise/callback in the certain circumstances.
greg-flexidao added a commit to greg-flexidao/web3.js that referenced this issue Sep 13, 2018
Causing endless wait for for tx receipt/hash
nivida pushed a commit that referenced this issue Apr 23, 2019
Update web3-eth-admin.rst
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this issue Jun 4, 2020
spacesailor24 added a commit that referenced this issue Jul 19, 2021
* Add additional EIP-2930 and EIP-1559 tests

* Update gasPrice to geth default minimum

* Replace hex number with number string

* Add test skip if using Ganache

* Add done function to ganache skip

* Add done function to ganache skip

* Update gasPrice params

* Bump gasPrice to Geth default

* Bump docker geth version to stable

* Gas price type number for 1 Gwei

* gasPrice type and backfills timeout change

* gasPrice type and test acct creation

* added nonce for geth auto nonce issue, removed auto acct creation

* Remove redundant London test. Add gasLimit field to London test

* Add validation for tx.maxPriorityFeePerGas and tx.maxFeePerGas

* Add additional 1559 tests

Co-authored-by: jdevcs <junaid@chainsafe.com>
Co-authored-by: jdevcs <junaid@chainsafe.io>
spacesailor24 added a commit that referenced this issue Jul 21, 2021
* npm run build for 1.4.0-rc.0

* v1.4.0-rc.0

* Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth

* Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth

* Fix typo

* WIP

* Fix type in error catch

Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>

* Remove commented code

* Update index for tx pricing info

* Correct order of if statements to properly assign tx type

* Update maxFeePerGas calculation

* Init _handleTxType function

* Update _handleTxPricing to use gasPrice for eip-1559 txs

* Fix bugs in _handleTxPricing

* Update tests for eip-1559 changes

* Fix BN bug: .mul only accepts BN instances

* eth.accounts.signTransaction: Add London tests

* Add EIP-1559 test without AccessList

* Add tx.common.hardfork check to _handleTxType

* Bug fixes

* Add additional undefined check in _handleTxType

* Add additional check for tx.hardfork in _handleTxType

* Add additional check for tx.hardfork in _handleTxType

* Update CHANGELOG

* Handling EIP1559 transactions in outputTransactionFormatter (#4167)

* Handing a null gasPrice and supporting maxFeePerGas and maxPriorityFeePerGas

* Updating gasPrice check

* Revert geth docker version tag

* Add additional EIP-2930 and EIP-1559 tests

* EIP 1559 Debug #2 (#4171)

* Add additional EIP-2930 and EIP-1559 tests

* Update gasPrice to geth default minimum

* Replace hex number with number string

* Add test skip if using Ganache

* Add done function to ganache skip

* Add done function to ganache skip

* Update gasPrice params

* Bump gasPrice to Geth default

* Bump docker geth version to stable

* Gas price type number for 1 Gwei

* gasPrice type and backfills timeout change

* gasPrice type and test acct creation

* added nonce for geth auto nonce issue, removed auto acct creation

* Remove redundant London test. Add gasLimit field to London test

* Add validation for tx.maxPriorityFeePerGas and tx.maxFeePerGas

* Add additional 1559 tests

Co-authored-by: jdevcs <junaid@chainsafe.com>
Co-authored-by: jdevcs <junaid@chainsafe.io>

* Update error message

Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>

* Update error message

Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>

* Update use of tx.type

* Replace hardfork strings with enum

* Type check refactors for _handleTxPricing

* Resolve tx.gasPrice if set and tx.type < 0x2 in _handleTxPricing

* Fix _handleTxType logic

Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>
Co-authored-by: Cory Smith <cory.m.smith@gmail.com>
Co-authored-by: jdevcs <junaid@chainsafe.com>
Co-authored-by: jdevcs <junaid@chainsafe.io>
mpetrunic added a commit that referenced this issue Jun 6, 2023
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
mpetrunic added a commit that referenced this issue Jun 7, 2023
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants