EIP 1559 Debug #2 #4171
Merged
EIP 1559 Debug #2 #4171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://web3-js-pr-4171.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c3kjbhk7o9q7tesg6tk0. |
|
Your Render PR Server URL is https://web3-js-pr-4171.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c3n8e69g7hpdifu5ij9g. |
Pull Request Test Coverage Report for Build 1046782989
💛 - Coveralls |
Merged
spacesailor24
added
1.x
spacesailor24
added a commit
that referenced
this pull request
Jul 21, 2021
* npm run build for 1.4.0-rc.0 * v1.4.0-rc.0 * Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth * Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth * Fix typo * WIP * Fix type in error catch Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com> * Remove commented code * Update index for tx pricing info * Correct order of if statements to properly assign tx type * Update maxFeePerGas calculation * Init _handleTxType function * Update _handleTxPricing to use gasPrice for eip-1559 txs * Fix bugs in _handleTxPricing * Update tests for eip-1559 changes * Fix BN bug: .mul only accepts BN instances * eth.accounts.signTransaction: Add London tests * Add EIP-1559 test without AccessList * Add tx.common.hardfork check to _handleTxType * Bug fixes * Add additional undefined check in _handleTxType * Add additional check for tx.hardfork in _handleTxType * Add additional check for tx.hardfork in _handleTxType * Update CHANGELOG * Handling EIP1559 transactions in outputTransactionFormatter (#4167) * Handing a null gasPrice and supporting maxFeePerGas and maxPriorityFeePerGas * Updating gasPrice check * Revert geth docker version tag * Add additional EIP-2930 and EIP-1559 tests * EIP 1559 Debug #2 (#4171) * Add additional EIP-2930 and EIP-1559 tests * Update gasPrice to geth default minimum * Replace hex number with number string * Add test skip if using Ganache * Add done function to ganache skip * Add done function to ganache skip * Update gasPrice params * Bump gasPrice to Geth default * Bump docker geth version to stable * Gas price type number for 1 Gwei * gasPrice type and backfills timeout change * gasPrice type and test acct creation * added nonce for geth auto nonce issue, removed auto acct creation * Remove redundant London test. Add gasLimit field to London test * Add validation for tx.maxPriorityFeePerGas and tx.maxFeePerGas * Add additional 1559 tests Co-authored-by: jdevcs <junaid@chainsafe.com> Co-authored-by: jdevcs <junaid@chainsafe.io> * Update error message Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com> * Update error message Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com> * Update use of tx.type * Replace hardfork strings with enum * Type check refactors for _handleTxPricing * Resolve tx.gasPrice if set and tx.type < 0x2 in _handleTxPricing * Fix _handleTxType logic Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com> Co-authored-by: Cory Smith <cory.m.smith@gmail.com> Co-authored-by: jdevcs <junaid@chainsafe.com> Co-authored-by: jdevcs <junaid@chainsafe.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.