Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpack5 support for angular-cli #4174

Closed
GregTheGreek opened this issue Jul 13, 2021 · 1 comment · Fixed by #4342
Closed

webpack5 support for angular-cli #4174

GregTheGreek opened this issue Jul 13, 2021 · 1 comment · Fixed by #4342
Assignees
@luu-alex
Labels
1.x 1.0 related issues

Comments

@GregTheGreek
Copy link
Contributor

GregTheGreek commented Jul 13, 2021 •
edited
Loading

When a user uses the Angular CLI to make their Angular project, it comes pre bundled with webpack 5. The scope will be to ensure that web3.js can be successfully bundled using webpack 5 and within an Angular project made with the Angular CLI.
@luu-alex luu-alex self-assigned this Jul 26, 2021
@philknows philknows added the 1.x 1.0 related issues label Aug 12, 2021
@luu-alex luu-alex mentioned this issue Sep 22, 2021
Merged
1 task
@luu-alex
Copy link
Contributor

luu-alex commented Sep 22, 2021 •
edited
Loading

The old instructions on the readme to solve this problem does not work in the latest angular version,
so in the upcoming PR I included instructions to solve the build error in the readme for the web3js library, to help out angular users when they run into this.

spacesailor24 added a commit that referenced this issue Sep 30, 2021
@spacesailor24
webpack 5 support angular instructions Closes #4174 (#4342)
202be5b 
Merging manually because this is a `README.md` change that won't cause tests to run

* updating readme and including instructions for angular fix

* updating instructions

* updated readme

* Formatting nitpick in CHANGELOG

* formatting

* Formatting and typos (#4343)

* Formatting and typos

* Update README.md

* Update formatting

* Formatting

* Update README.md

Co-authored-by: Wyatt Barnes <wyatt@writerof.software>
@sync-by-unito sync-by-unito bot mentioned this issue Oct 1, 2021
Closed
@spacesailor24 spacesailor24 mentioned this issue Oct 9, 2021
Merged
@sync-by-unito sync-by-unito bot mentioned this issue Dec 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this issue Feb 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this issue May 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this issue Jul 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this issue Aug 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this issue Aug 28, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this issue Sep 15, 2022
Closed
@baby636 baby636 mentioned this issue Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luu-alex luu-alex

Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

webpack 5 support angular instructions Closes #4174 web3/web3.js
3 participants
@GregTheGreek @luu-alex @philknows