-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webpack 5 support angular instructions Closes #4174 #4342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luu-alex
changed the title
webpack 5 support instruction Closes #4174
webpack 5 support angular instructions Closes #4174
Sep 22, 2021
Your Render PR Server URL is https://web3-js-pr-4342.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c558a59g7hpaq87b48r0. |
Your Render PR Server URL is https://web3-js-pr-4342-k38u.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c558a5hg7hpaq87b4abg. |
…into al/4174-webpack
Merged
* Formatting and typos * Update README.md * Update formatting * Formatting * Update README.md
jdevcs
previously approved these changes
Sep 22, 2021
spacesailor24
previously approved these changes
Sep 22, 2021
spacesailor24
previously approved these changes
Sep 22, 2021
jdevcs
previously approved these changes
Sep 23, 2021
nazarhussain
requested changes
Sep 23, 2021
nazarhussain
previously approved these changes
Sep 27, 2021
luu-alex
dismissed stale reviews from nazarhussain, jdevcs, and spacesailor24
via
September 29, 2021 16:00
99a6797
nazarhussain
previously approved these changes
Sep 30, 2021
jdevcs
previously approved these changes
Sep 30, 2021
jdevcs
approved these changes
Sep 30, 2021
spacesailor24
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4174
Type of change
Updates readme and includes instructions to support webpack 5 on angular
Checklist:
CHANGELOG.md
file in the root folder.