Fixes to TypeScript definitions #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.signTransaction documentation
…s.signTransaction documentation
renamed accounts.privateToAccount to accounts.privateKeyToAccount Added missing Contract.options Added status to TransactionReceipt
frozeman
approved these changes
Oct 24, 2017
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* removed privateKey from web3.eth.signTransaction and web3.eth.accounts.signTransaction documentation * removed privateKey from web3.eth.signTransaction and web3.eth.accounts.signTransaction documentation * added vscode to gitignore and minor doco change * Added test to show privateKey can not be passed to accounts.signTransaction * removed passing of private key * Added Eth.signTransaction function renamed accounts.privateToAccount to accounts.privateKeyToAccount Added missing Contract.options Added status to TransactionReceipt * reversing changes so my forked 1.0 branch is in sync with the upstream 1.0 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Eth.signTransaction
Renamed accounts.privateToAccount to accounts.privateKeyToAccount
Added missing types in Contract.options
Added status to TransactionReceipt