Fixes in types definition #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interfaces to make a OR between them
|
Following this answer, I decided to make the |
frozeman
approved these changes
Nov 13, 2017
|
Hoping this makes sense, as i didn't test the typescript compiler |
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* Fixes in types definition * Fix Provider type: implement 'empty' variables to the other providers interfaces to make a OR between them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements #1131 and fixes some issues that broke my code after implementation of type definitons
bignumber.jstobn.jsProviderinterface toIProviderand createProvidertype, which is a union of all the 3 providers (HttpProvider & IpcProvider & WebsocketProvider)web3-providers-ws