Geth "Miner and DAG" management API's implemented (web3-eth-miner)

[princesinha19]

Description

I implemented all miner management API's provided by geth.
https://github.com/ethereum/go-ethereum/wiki/Management-APIs#list-of-management-apis

Fixes #2637 Partially

Type of change

• New feature

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no warnings.
• I have updated or added types for all modules I've changed
• Any dependent changes have been merged and published in downstream modules.
• I ran npm run test in the root folder with success and extended the tests if necessary.
• I ran npm run build in the root folder and tested it in the browser and with node.
• I ran npm run dtslint in the root folder and tested that all my types are correct
• I have tested my code on an ethereum test network.

[coveralls]

Coverage increased (+0.05%) to 95.545% when pulling 4ab586e on princesinha19:miner-methods into bb891b2 on ethereum:1.0.

[joshstevens19]

If this has to get to through web3.eth you have to add this to the Eth typings class or it wont be exposed in the global scope when ts users try to use it.

https://github.com/ethereum/web3.js/blob/1.0/packages/web3-eth/types/index.d.ts

Please add it

[princesinha19]

If this has to get to through web3.eth you have to add this to the Eth typings class or it wont be exposed in the global scope when ts users try to use it.

https://github.com/ethereum/web3.js/blob/1.0/packages/web3-eth/types/index.d.ts

Please add it

Why it is so, web3-eth-miner is an independent module and it has it's own typing class. So, what's the need to check type in web3-eth. This is same for web3-eth-personal and all other modules. I think this dependency should be removed. Correct me if I am wrong @joshstevens19.
@nivida

[joshstevens19]

@princesinha19 @nivida that's not true. If you want to get to web3.eth.personal through the main web3 class - https://web3js.readthedocs.io/en/1.0/web3-eth.html#personal

In code you have to write web3.eth.personal if personal is not on the web3.eth typing's you can never get to it https://github.com/ethereum/web3.js/blob/1.0/packages/web3-eth/types/index.d.ts#L50

I am not saying check types in web3.eth just exposing them as the above link shows ^^ BUT I think all your PRs are standalone modules the user should only be able to get to it if they import the module and not through the public interface. If that's the case then great and shouldn't add them to web3.eth.

If you remove this it will break and not compile in typescript. You need to expose this on the web3-eth typing's interface if you want people to be able to get to it through there like personal. If you don't want web3-eth-miner to ever be able to be accessed through web3.eth and import only then that's fine.

We can not remove web3.eth.personal as it will break what the docs say which people support and then break TS apps.

[princesinha19]

@joshstevens19 can you please review this too?

[joshstevens19]

You have some conflicts to resolve @princesinha19 👍