Add eth2 github action #3892
Add eth2 github action #3892
Conversation
Pull Request Test Coverage Report for Build 521583702Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
spacesailor24
requested review from
GregTheGreek,
frankiebee and
koraykoska
and removed request for
GregTheGreek
| @@ -10,18 +10,27 @@ | |||
| "types": "types.ts", | |||
| "scripts": { | |||
| "test": "jest", | |||
| "tsc": "babel src --out-dir lib --extensions \".ts,.tsx\" --source-maps inline" | |||
| "tsc": "babel src --out-dir lib --extensions \".ts,.tsx\" --source-maps inline", | |||
There was a problem hiding this comment.
should this be renamed ?
There was a problem hiding this comment.
I would like it to be, but some of our CI scripts use lerna exec tsc. Perhaps we can open a separate PR to update the scripts/npm commands to compile instead of tsc?
There was a problem hiding this comment.
yeah that makes sense!
| @@ -135,7 +135,7 @@ it('getValidatorBalances', async () => { | |||
| expect(response[0]).toMatchObject(expectedResponse) | |||
| }) | |||
|
|
|||
| it('getEpochCommittees', async () => { | |||
| xit('getEpochCommittees', async () => { | |||
There was a problem hiding this comment.
Sorry this got posted, but it was still pending
| @@ -135,7 +135,7 @@ it('getValidatorBalances', async () => { | |||
| expect(response[0]).toMatchObject(expectedResponse) | |||
| }) | |||
|
|
|||
| it('getEpochCommittees', async () => { | |||
| xit('getEpochCommittees', async () => { | |||
There was a problem hiding this comment.
Temp fix, getting a 400 because route is wrong, but I don't understand why I would've made the route what it is, if it wasn't supposed to be - need to further investigate and changes should probably be in a separate PR
This reverts commit 1a252a9.
Description
Adds Github action that runs tests for ETH2 packages:
web3-eth2-coreandweb3-eth2-beaconchainIncludes changes from #3890 so that ETH2 tests are passing
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.