Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.5-rc.0 #3966

Closed
wants to merge 5 commits into from
Closed

Release 1.3.5-rc.0 #3966

wants to merge 5 commits into from

Conversation

spacesailor24
Copy link
Contributor

Added

Changed

@render
Copy link

render bot commented Mar 18, 2021

@render
Copy link

render bot commented Mar 18, 2021

koraykoska
koraykoska previously approved these changes Mar 19, 2021
Copy link

@koraykoska koraykoska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side!

* Rename tsc to compile (#3957) (#3958)

* Change 'tsc' command in scripts & lerna run to 'compile'

* Update changelog

* Undo incorrect rename

* Checking if e2e test is deterministic

Co-authored-by: Sam Hodak <slhodak@gmail.com>

Co-authored-by: Sam Hodak <slhodak@gmail.com>

* Debugging failing tests (#3959) (#3960)

* Remote node provider edits

* remote node provider documentation edits

Co-authored-by: smudgil <38195323+smudgil@users.noreply.github.com>

Co-authored-by: smudgil <38195323+smudgil@users.noreply.github.com>

* Clarify commitment to semantic versioning (#3961) (#3962)

see discussion in the issue #3758

Co-authored-by: LudwikJaniuk <ludvig.janiuk@gmail.com>

Co-authored-by: LudwikJaniuk <ludvig.janiuk@gmail.com>

* Feature/web3 eth iban es6 (#3964) (#3965)

* Feature/web3 eth iban es6 (#3964)

* web3-eth-iban es6 rewrite - replace `var` with `const` and `let`

* web3-eth-iban es6 rewrite - replace object prototype with class

* web3-eth-iban code style fix

Co-authored-by: Loredana <loredana.cirstea@gmail.com>

* Update changelog

Co-authored-by: Loredana <loredana.cirstea@gmail.com>

* Update changelog for PR 3961

* Built lib

Co-authored-by: Sam Hodak <slhodak@gmail.com>
Co-authored-by: smudgil <38195323+smudgil@users.noreply.github.com>
Co-authored-by: LudwikJaniuk <ludvig.janiuk@gmail.com>
Co-authored-by: Loredana <loredana.cirstea@gmail.com>
@render
Copy link

render bot commented Mar 23, 2021

@spacesailor24 spacesailor24 changed the title Release/1.3.5 Release 1.3.5-rc.0 Mar 23, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 680117814

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.702%

Totals Coverage Status
Change from base Build 663272150: 0.0%
Covered Lines: 3277
Relevant Lines: 4208

💛 - Coveralls

@spacesailor24
Copy link
Contributor Author

Replicating the steps mentioned in previous releases

As part of the RC process, am doing some test installations in other projects and running their tests to see if everything.

  • installs properly
  • builds
  • tests pass

(This list will be actively edited)

Project Desc Status
oz-test-helpers Test utils. Subset of their suite is web3 contracts ✔️
synthetix ~1000 units

Synthetic tests failed with same JavaScript heap out of memory as last release:

  Contract: Exchange Rates
     only expected functions should be mutative (262ms)
    constructor
       should set constructor params on deployment (512ms)
       two different currencies in same array should mean that the second one overrides (575ms)
       should revert when number of currency keys > new rates length on create (421ms)
       should limit to 32 bytes if currency key > 32 bytes on create (1003ms)
       shouldn't be able to set exchange rate to 0 on create (426ms)

<--- Last few GCs --->

[8287:0x3724ef0]  1458092 ms: Scavenge 1359.3 (1423.4) -> 1359.1 (1423.9) MB, 3.3 / 0.0 ms  (average mu = 0.301, current mu = 0.255) allocation failure 
[8287:0x3724ef0]  1458096 ms: Scavenge 1359.6 (1423.9) -> 1359.4 (1424.9) MB, 3.1 / 0.0 ms  (average mu = 0.301, current mu = 0.255) allocation failure 
[8287:0x3724ef0]  1458100 ms: Scavenge 1359.9 (1424.9) -> 1359.6 (1425.4) MB, 3.4 / 0.0 ms  (average mu = 0.301, current mu = 0.255) allocation failure 


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x3a79ad39e6e9 <JSObject>
    0: builtin exit frame: concat(this=0x35b7a216e5a9 <JSArray[38784]>,0x2b8dc53d0591 <JSArray[32]>,0x35b7a216e5a9 <JSArray[38784]>)

    1: MSTORE(aka MSTORE) [0x2ef33954a4d1] [/home/anon/tmp/synthetix/node_modules/@nomiclabs/ethereumjs-vm/dist/evm/opFns.js:~445] [pc=0x24733b4d2d88](this=0x0010e80822b1 <null>,runState=0x3dcafb165961 <Object map = 0x380bdb91a89>)
    2: runStep [0x381ef1463591] ...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8fa090 node::Abort() [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 2: 0x8fa0dc  [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 3: 0xb0052e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 4: 0xb00764 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 5: 0xef4c72  [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 6: 0xef4d78 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 7: 0xf00e52 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 8: 0xf01784 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 9: 0xf043f1 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
10: 0xecd4e6 v8::internal::Factory::AllocateRawArray(int, v8::internal::PretenureFlag) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
11: 0xecdd6a v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::Heap::RootListIndex, int, v8::internal::Object*, v8::internal::PretenureFlag) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
12: 0xeda751 v8::internal::Factory::NewJSArrayStorage(v8::internal::Handle<v8::internal::JSArray>, int, int, v8::internal::ArrayStorageAllocationMode) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
13: 0xedaa4c v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, int, int, v8::internal::ArrayStorageAllocationMode, v8::internal::PretenureFlag) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
14: 0xe93e81 v8::internal::ElementsAccessor::Concat(v8::internal::Isolate*, v8::internal::Arguments*, unsigned int, unsigned int) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
15: 0xb8fcc9  [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
16: 0xb993c8 v8::internal::Builtin_ArrayConcat(int, v8::internal::Object**, v8::internal::Isolate*) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
17: 0x24733a25bf7d 
Aborted (core dumped)
error Command failed with exit code 134.

@spacesailor24
Copy link
Contributor Author

Closing to fix merge conflict issues

@spacesailor24 spacesailor24 deleted the fix/release branch March 24, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants