Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Types] Fix typo in BlockHeader type #5110

Closed
wants to merge 3 commits into from
Closed

Conversation

marcelltoth
Copy link

@marcelltoth marcelltoth commented Jun 7, 2022

Description

There was a typo in the typings for BlockHeader. As documented here blocks have a transactionsRoot property, but the typings spelled it as transactionRoot. Of course that property does not exist and will result in undefined values when using.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch. - I think
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas. N/A
  • I have made corresponding changes to the documentation. N/A
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary. N/A
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code. N/A
  • I ran npm run build with success. N/A (Won't CI run these anyway though?)
  • I have tested the built dist/web3.min.js in a browser. N/A
  • I have tested my code on the live network. N/A
  • I have checked the Deploy Preview and it looks correct. What is this?
  • I have updated the CHANGELOG.md file in the root folder. How do I do so exactly, without knowing the version number upfront?

@jdevcs jdevcs added 1.x 1.0 related issues Future Release For future release. labels Jun 9, 2022
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcelltoth Thanks for this PR. changelog update is also required under 1.7.5

@coveralls
Copy link

coveralls commented Jun 9, 2022

Pull Request Test Coverage Report for Build 2544291381

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 266 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.3%) to 74.517%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 7 85.42%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 43 31.38%
packages/web3-utils/src/utils.js 45 10.67%
packages/web3-eth-accounts/src/index.js 107 23.67%
Totals Coverage Status
Change from base Build 2536784248: 2.3%
Covered Lines: 3251
Relevant Lines: 4117

💛 - Coveralls

@jdevcs
Copy link
Contributor

jdevcs commented Jun 9, 2022

Same changes PR as #5083

@nazarhussain
Copy link
Contributor

As the PR #5083 with same change was created earlier, so I am closing this one.

@marcelltoth marcelltoth deleted the patch-1 branch June 24, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Future Release For future release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants