[Types] Fix typo in BlockHeader type #5110
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a typo in the typings for
BlockHeader
. As documented here blocks have atransactionsRoot
property, but the typings spelled it astransactionRoot
. Of course that property does not exist and will result inundefined
values when using.Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary. N/Anpm run test:cov
and my test cases cover all the lines and branches of the added code. N/Anpm run build
with success. N/A (Won't CI run these anyway though?)dist/web3.min.js
in a browser. N/ACHANGELOG.md
file in the root folder. How do I do so exactly, without knowing the version number upfront?