-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6201 multi provider #6825
6201 multi provider #6825
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged No assets were unchanged |
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
window.addEventListener( | ||
Eip6963EventName.eip6963announceProvider as any, | ||
(event: EIP6963AnnounceProviderEvent) => { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not emitting eip6963:announceProvider event here via web3promi
events as discussed in issue, because,
-
if user is listening to eip6963:announceProvider event after using this utility method then this utility method is just additional overlapping work also listening to same event and re-emitting without any need of processing,
-
EIP 6963 clearly specifies "... MUST use the
window.dispatchEvent
function toemit
events and MUST use thewindow.addEventListener
function toobserve
events ... ",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be stated somewhere that we return web3promievent for the users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
web3promievent
is not returned due to above reasons.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6825 +/- ##
==========================================
+ Coverage 87.37% 92.05% +4.68%
==========================================
Files 197 215 +18
Lines 7548 8206 +658
Branches 2059 2208 +149
==========================================
+ Hits 6595 7554 +959
+ Misses 953 652 -301
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Also, it will be great to have some section in docs that explain how to use requestEIP6963Providers
LGTM other than oleksii's feedback |
Description
#6201
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.