-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6201 multi provider #6825
Merged
Merged
6201 multi provider #6825
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b6fad50
requestEIP6963Providers function
jdevcs a389d57
requestEIP6963Providers in web3 class
jdevcs c01ebc0
changelog update
jdevcs c0e9354
unit test
jdevcs 146faad
removed unused file
jdevcs 6fe67a7
lint fix
jdevcs 702def0
added doc
jdevcs c7960e1
Merge branch '4.x' into junaid/6201multiprovider
avkos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/* | ||
This file is part of web3.js. | ||
|
||
web3.js is free software: you can redistribute it and/or modify | ||
it under the terms of the GNU Lesser General Public License as published by | ||
the Free Software Foundation, either version 3 of the License, or | ||
(at your option) any later version. | ||
|
||
web3.js is distributed in the hope that it will be useful, | ||
but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
GNU Lesser General Public License for more details. | ||
|
||
You should have received a copy of the GNU Lesser General Public License | ||
along with web3.js. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
import { Web3APISpec, EIP1193Provider } from "web3-types"; | ||
|
||
|
||
export enum Eip6963EventName { | ||
eip6963announceProvider = 'eip6963:announceProvider', | ||
eip6963requestProvider = 'eip6963:requestProvider', | ||
}; | ||
|
||
export interface EIP6963ProviderInfo { | ||
uuid: string; | ||
name: string; | ||
icon: string; | ||
rdns: string; | ||
} | ||
|
||
export interface EIP6963ProviderDetail<API = Web3APISpec> { | ||
info: EIP6963ProviderInfo; | ||
provider: EIP1193Provider<API>; | ||
} | ||
|
||
export interface EIP6963AnnounceProviderEvent<API = Web3APISpec> extends CustomEvent { | ||
type: Eip6963EventName.eip6963announceProvider; | ||
detail: EIP6963ProviderDetail<API>; | ||
} | ||
|
||
export interface EIP6963RequestProviderEvent extends Event { | ||
type: Eip6963EventName.eip6963requestProvider; | ||
} | ||
|
||
export const eip6963Providers: Map<string, EIP6963ProviderDetail> = new Map(); | ||
|
||
export const requestEIP6963Providers = () => { | ||
|
||
if (window === undefined) | ||
throw new Error( | ||
"window object not available, EIP-6963 is intended to be used within a browser" | ||
); | ||
|
||
window.addEventListener( | ||
Eip6963EventName.eip6963announceProvider as any, | ||
(event: EIP6963AnnounceProviderEvent) => { | ||
|
||
eip6963Providers.set( | ||
event.detail.info.uuid, | ||
event.detail); | ||
} | ||
); | ||
|
||
window.dispatchEvent(new Event(Eip6963EventName.eip6963requestProvider)); | ||
|
||
return eip6963Providers; | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not emitting eip6963:announceProvider event here via
web3promi
events as discussed in issue, because,if user is listening to eip6963:announceProvider event after using this utility method then this utility method is just additional overlapping work also listening to same event and re-emitting without any need of processing,
EIP 6963 clearly specifies "... MUST use the
window.dispatchEvent
function toemit
events and MUST use thewindow.addEventListener
function toobserve
events ... ",There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be stated somewhere that we return web3promievent for the users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
web3promievent
is not returned due to above reasons.