Incorrect function

[YuryStrozhevsky]

Seems you at least incorrectly named this function. And in order to get serialNumber would could use this code:

import { bufferToHexCodes } from "pvutils";
const serialNumber = bufferToHexCodes(certificate.serialNumber.valueBlock.valueHex);

or this one:

const serialNumber = certificate.serialNumber.valueBlock.toString(); // for decimal representation, even for huge serial numbers

[YuryStrozhevsky]

And having this is not a good idea :)

    getIssuer() {
        return this._cert.issuer.typesAndValues[0].value.valueBlock.value;
    }

It is not a good idea because no one could be 100% sure that first element in typesAndValues would be able to be represented as string. Yes, in most cases you would get no problems. But anyway I do suggest you to at least search for commonName OID and return its string represemtation in your getIssuer function.

[apowers313]

Thanks for the review and the feedback. I'll go back and make your recommended changes.

I have to admit that trying to figure out how to interpret values from the certs has been a trial-and-error process. Half of that has been trying to understand the data structure created by pki.js -- it's not entirely clear to me how to get to the values for the different fields -- although I think I have learned quite a bit (or maybe developed strange coping mechanisms) about that along the way. If / when you write documentation for pki.js this might be one of the good initial areas to focus on.

[YuryStrozhevsky]

Documentation for such a huge code would be a nightmare :) But I will consider this for sure.

[JamesCullum]

Looks like a good first issue for contributors - waiting for a PR