Add fixes for getIssuer and getSerial (#15) #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add search for commonName in getIssuer * Properly return serial number from _cert in getSerial
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #138 +/- ##
==========================================
- Coverage 92.97% 92.85% -0.12%
==========================================
Files 16 16
Lines 6007 6019 +12
==========================================
+ Hits 5585 5589 +4
- Misses 422 430 +8
☔ View full report in Codecov by Sentry. |
|
Welcome and thanks for your contribution! I will review the code and share some questions or improvements with you. Would be great if you could explain your reasoning behind it and maybe improve parts to help us understand. |
JamesCullum
reviewed
Sep 15, 2023
JamesCullum
reviewed
Sep 17, 2023
JamesCullum
reviewed
Sep 19, 2023
JamesCullum
reviewed
Sep 19, 2023
RyanHopkins7
commented
Sep 19, 2023
RyanHopkins7
commented
Sep 19, 2023
… common name is used as a key instead of the serial number
JamesCullum
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I know this is a pretty old issue so I figured I'd take it up. This is my first contribution to an open source library. :-)
I've added fixes for the getIssuer and getSerial functions in certUtils as requested in #15. It'll no longer be necessary to index directly into
typesAndValues. Please let me know if there's anything else that I'm missing!