Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent tooltip on focus #4318

Merged
merged 4 commits into from
Oct 21, 2024
Merged

fix: Prevent tooltip on focus #4318

merged 4 commits into from
Oct 21, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Oct 19, 2024

Description

closes #4293

One of solution also

        onCloseAutoFocus={(event) => {
          event.preventDefault();
        }}

on dialog and popover content, but it's lost element focus.

This solution doesn't lost focus. Just prevent tooltip from being shown on focus.

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested a review from kof October 19, 2024 19:43
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment about WHY we decided to do that

@istarkov istarkov merged commit 73328b3 into main Oct 21, 2024
13 of 15 checks passed
@istarkov istarkov deleted the fix-scroll branch October 21, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After using expression editor, canvas loses focus
3 participants