Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltips trigger without a delay #4419

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: Tooltips trigger without a delay #4419

merged 1 commit into from
Nov 14, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Nov 13, 2024

Partially (or may be fully) Fixes #4406
Closes #4410
Some issues can't be fixed with current tooltips - i.e. if hover from tooltip is going onto the canvas we can't set delay on hover back.

Description

  1. Fixes focusable buttons had tooltip.

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov changed the title Tooltips trigger without a delay fix: Tooltips trigger without a delay Nov 13, 2024
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick test and didn't see a single one. 🤞 THANK YOU

@istarkov istarkov merged commit ad04a72 into main Nov 14, 2024
16 of 21 checks passed
@istarkov istarkov deleted the istarkov/issue4406 branch November 14, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hovering a close button shows unrelated tooltip Tooltips trigger without a delay
2 participants