feat: Add support for linea_estimateGas #2525

wantedsystem · 2024-07-23T10:08:16Z

Linea, a layer 2 blockchain, supports the Ethereum EIP-1559 gas price model, known for making transaction fees more predictable. Unlike the base Ethereum layer, Linea aims to offer a more stable and cost-effective approach to handling transaction fees. For detailed information, you can visit Linea's Gas Fees Documentation.

To further enhance the efficiency of transaction fee calculations, Linea has introduced a new RPC method designed to provide the best gas price estimates. This new method is documented in detail here.

The introduction of this new RPC method necessitates changes in how web3 libraries calculate gas prices. Traditionally, these libraries used the eth_gasPrice method. Linea's update shifts this approach to utilize the newly introduced linea_estimateGas method.

Detailed summary

Added linea_estimateGas RPC method to calculate accurate gas price on Linea network
Updated linea and lineaTestnet definitions to override fee calculation using linea_estimateGas
Added lineaEstimateGas and lineaEstimateFeesPerGas actions to calculate gas and fees
Updated types and imports related to fee calculation on Linea network

PR-Codex overview

This PR adds Linea and Linea Testnet chains with gas estimation and fee calculation support.

Detailed summary

Added Linea and Linea Testnet chains
Implemented gas estimation and fee calculation
Added lineaEstimateGas and lineaEstimateFeesPerGas functions
Updated chain configurations and RPC schemas

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-07-23T10:08:19Z

⚠️ No Changeset found

Latest commit: a5c1675

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-07-23T10:08:20Z

@wantedsystem is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

jxom · 2024-07-23T11:12:36Z

src/linea/actions/lineaEstimateFeesPerGas.ts

+    try {
+      // Try with the public endpoint
+      const publicClient = createPublicClient({
+        chain: client.chain.id === linea.id ? linea : lineaTestnet,
+        transport: http(),
+      })
+      lineaEstimateGasResponse = await getAction(
+        publicClient,
+        lineaEstimateGas,
+        'lineaEstimateGas',
+      )({
+        data: request.data,
+        to: request.to,
+        ...request,
+      } as unknown as EstimateGasParameters)
+    } catch (_err) {


Consumers can set up fallback transport if they want this behavior.

Suggested change

try {

// Try with the public endpoint

const publicClient = createPublicClient({

chain: client.chain.id === linea.id ? linea : lineaTestnet,

transport: http(),

})

lineaEstimateGasResponse = await getAction(

publicClient,

lineaEstimateGas,

'lineaEstimateGas',

)({

data: request.data,

to: request.to,

...request,

} as unknown as EstimateGasParameters)

} catch (_err) {

Hey @jxom thanks for reviewing ! Could you please confirm if I need to change transport: http() to transport: fallback([http(), webSocket()]) here ?

I mean we can omit this section of code, and just rely on fallback mechanisms that the consumer defines.

jxom · 2024-07-23T22:45:17Z

src/linea/actions/lineaEstimateFeesPerGas.ts

+  const adjustedBaseFee =
+    (BigInt(baseFeePerGas) * BigInt(BASE_FEE_PER_GAS_MARGIN * 100)) /
+    BigInt(100)


Can we rely on multiply here? This is default to 1.2, but can be adjusted to 1.35 via chain.fees.baseFeeMultiplier

Suggested change

const adjustedBaseFee =

(BigInt(baseFeePerGas) * BigInt(BASE_FEE_PER_GAS_MARGIN * 100)) /

BigInt(100)

const adjustedBaseFee = multiply(BigInt(baseFeePerGas))

hey @jxom we will keep the default value 1.2

jxom · 2024-07-26T01:30:16Z

Attempting to test this end-to-end, but I am running into issues on Linea Sepolia that the method linea_estimateGas is not available:

$ curl -X POST https://rpc.sepolia.linea.build \
     -H "Content-Type: application/json" \
     -d '{"id": 1, "jsonrpc": "2.0", "method": "linea_estimateGas", "params": [{"to": "0x70997970c51812dc3a010c7d01b50e0d17dc79c8", "value": "0xde0b6b3a7640000"}]}'
     
> {"jsonrpc":"2.0","id":1,"error":{"code":-32601,"message":"the method linea_estimateGas does not exist/is not available"}}

What RPC URL can I use to test this end-to-end?

wantedsystem · 2024-07-26T12:36:59Z

Attempting to test this end-to-end, but I am running into issues on Linea Sepolia that the method linea_estimateGas is not available:
$ curl -X POST https://rpc.sepolia.linea.build \
     -H "Content-Type: application/json" \
     -d '{"id": 1, "jsonrpc": "2.0", "method": "linea_estimateGas", "params": [{"to": "0x70997970c51812dc3a010c7d01b50e0d17dc79c8", "value": "0xde0b6b3a7640000"}]}'
     
> {"jsonrpc":"2.0","id":1,"error":{"code":-32601,"message":"the method linea_estimateGas does not exist/is not available"}}
What RPC URL can I use to test this end-to-end?

Hey @jxom It will be available soon -i'll keep you posted

tmm · 2024-07-30T21:11:32Z

src/chains/definitions/linea.ts

+  fees: {
+    // Override the fees calculation to accurately price the fees
+    // on Linea using the rpc call linea_estimateGas
+    estimateFeesPerGas: lineaEstimateFeesPerGas,
+    async defaultPriorityFee(args): Promise<bigint> {
+      const { maxPriorityFeePerGas } = await lineaEstimateFeesPerGas({
+        client: args.client,
+        request: args.request,
+        type: 'eip1559',
+      } as any)
+
+      if (maxPriorityFeePerGas === undefined) {
+        throw new Error('maxPriorityFeePerGas is undefined')
+      }
+
+      return maxPriorityFeePerGas
+    },
+  },


Can you set up a shared chainConfig object and spread it into the Linea chain definitions? (Similar to how things are set up for OP Stack and Zksync support.)

// src/linea/chainConfig.ts import type { Chain } from '../types/chain.js' export const chainConfig = { fees: { // Override the fees calculation to accurately price the fees // on Linea using the rpc call linea_estimateGas async estimateFeesPerGas(args) { ... }, async defaultPriorityFee(args) { ... }, }, } as const satisfies Pick<Chain, 'fees'>

// src/chains/definitions/linea.ts import { chainConfig } from '../../linea/chainConfig.js' import { defineChain } from '../../utils/chain/defineChain.js' export const linea = /*#__PURE__*/ defineChain({ ...chainConfig, id: 59_144, name: 'Linea Mainnet', // other properties ... })

tmm · 2024-07-30T21:12:09Z

src/chains/definitions/lineaSepolia.ts

See previous comment on linea.ts about chainConfig

tmm · 2024-07-30T21:19:47Z

src/linea/actions/lineaEstimateFeesPerGas.ts

Let's move to src/linea/utils/estimateFeesPerGas.ts or inline into chainConfig.

tmm · 2024-07-30T21:20:42Z

src/linea/actions/lineaEstimateGas.ts

+ *   value: 0n,
+ * })
+ */
+export async function lineaEstimateGas<


Let's drop the linea prefix since it will be namespaced by the import 'viem/linea'.

tmm · 2024-07-30T21:24:21Z

src/linea/actions/lineaEstimateGas.ts

+  TAccount extends Account | undefined = undefined,
+>(
+  client: Client<Transport, TChain, TAccount>,
+  args: EstimateGasParameters<TChain>,


Let's add a type for EstimateGasParameters

import type { EstimateGasParameters as base_EstimateGasParameters } from '../../actions/public/estimateGas.js' export type EstimateGasParameters = base_EstimateGasParameters

Can you provide more informations on what to do here ?

tmm · 2024-07-30T21:24:43Z

src/linea/actions/lineaEstimateGas.ts

+  type AssertRequestParameters,
+  assertRequest,
+} from '../../utils/transaction/assertRequest.js'
+import type { LineaEstimateGasReturnType } from '../types/fee.js'


Let's add this return type directly to this file

We are also using it in src/linea/utils/estimateFeesPerGas.ts so we had to duplicate the type here as well

tmm · 2024-07-30T21:27:49Z

src/linea/types/rpc.ts

+  {
+    Method: 'linea_estimateGas'
+    Parameters?: any
+    ReturnType: LineaEstimateGasReturnType


Let's inline ReturnType. Duplication is fine in this case.

Suggested change

ReturnType: LineaEstimateGasReturnType

ReturnType: {

gasLimit: Hex

baseFeePerGas: Hex

priorityFeePerGas: Hex

}

tmm · 2024-07-30T21:30:03Z

src/linea/types/rpc.ts

+   */
+  {
+    Method: 'linea_estimateGas'
+    Parameters?: any


Let's type this. See EIP-1993 types for inspiration.

tmm · 2024-07-30T21:30:37Z

src/linea/types/fee.ts

Let's colocate these with their actions/utils and export from those places as needed.

tmm · 2024-08-06T12:55:38Z

Since there are a few outstanding comments, going to convert this to a draft.

wantedsystem · 2024-08-12T15:48:34Z

Attempting to test this end-to-end, but I am running into issues on Linea Sepolia that the method linea_estimateGas is not available:
$ curl -X POST https://rpc.sepolia.linea.build \
     -H "Content-Type: application/json" \
     -d '{"id": 1, "jsonrpc": "2.0", "method": "linea_estimateGas", "params": [{"to": "0x70997970c51812dc3a010c7d01b50e0d17dc79c8", "value": "0xde0b6b3a7640000"}]}'
     
> {"jsonrpc":"2.0","id":1,"error":{"code":-32601,"message":"the method linea_estimateGas does not exist/is not available"}}
What RPC URL can I use to test this end-to-end?

You can test now for Linea Mainnet

curl https://rpc.linea.build \
       -X POST \
       -H "Content-Type: application/json" \
       -d '{"jsonrpc": "2.0","method": "linea_estimateGas","params": [{"from": "0x91ba6c8DE41deC8E4d4E1C858f00FaE1819990Ca","gas":"0x21000"}],"id": 53}'

And for Linea Sepolia :

curl https://rpc.sepolia.linea.build \
       -X POST \
       -H "Content-Type: application/json" \
       -d '{"jsonrpc": "2.0","method": "linea_estimateGas","params": [{"from": "0x91ba6c8DE41deC8E4d4E1C858f00FaE1819990Ca","gas":"0x21000"}],"id": 53}'

wantedsystem · 2024-08-20T15:43:06Z

Attempting to test this end-to-end, but I am running into issues on Linea Sepolia that the method linea_estimateGas is not available:
$ curl -X POST https://rpc.sepolia.linea.build \
     -H "Content-Type: application/json" \
     -d '{"id": 1, "jsonrpc": "2.0", "method": "linea_estimateGas", "params": [{"to": "0x70997970c51812dc3a010c7d01b50e0d17dc79c8", "value": "0xde0b6b3a7640000"}]}'
     
> {"jsonrpc":"2.0","id":1,"error":{"code":-32601,"message":"the method linea_estimateGas does not exist/is not available"}}
What RPC URL can I use to test this end-to-end?

You can test now for Linea Mainnet

curl https://rpc.linea.build \
       -X POST \
       -H "Content-Type: application/json" \
       -d '{"jsonrpc": "2.0","method": "linea_estimateGas","params": [{"from": "0x91ba6c8DE41deC8E4d4E1C858f00FaE1819990Ca","gas":"0x21000"}],"id": 53}'

And for Linea Sepolia :

curl https://rpc.sepolia.linea.build \
       -X POST \
       -H "Content-Type: application/json" \
       -d '{"jsonrpc": "2.0","method": "linea_estimateGas","params": [{"from": "0x91ba6c8DE41deC8E4d4E1C858f00FaE1819990Ca","gas":"0x21000"}],"id": 53}'

Hey @jxom you had the opportunity to test ?

jxom · 2024-08-29T00:30:01Z

Superseded by #2665

feat: Add support for linea_estimateGas

f048c32

wantedsystem mentioned this pull request Jul 23, 2024

feat: Add support for linea_estimateGas #2518

Closed

jxom reviewed Jul 23, 2024

View reviewed changes

fix: fix returns

40ee9e1

tmm reviewed Jul 30, 2024

View reviewed changes

tmm marked this pull request as draft August 6, 2024 12:55

fix: lineaEstimateGas refactoring

a5c1675

jxom marked this pull request as ready for review August 28, 2024 11:42

jxom self-assigned this Aug 28, 2024

jxom closed this Aug 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add support for linea_estimateGas #2525

feat: Add support for linea_estimateGas #2525

wantedsystem commented Jul 23, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Jul 23, 2024 •

edited

Loading

vercel bot commented Jul 23, 2024

jxom Jul 23, 2024

wantedsystem Jul 23, 2024

jxom Jul 23, 2024

jxom Jul 23, 2024

wantedsystem Jul 25, 2024

jxom commented Jul 26, 2024 •

edited

Loading

wantedsystem commented Jul 26, 2024

tmm Jul 30, 2024

tmm Jul 30, 2024

tmm Jul 30, 2024

tmm Jul 30, 2024

tmm Jul 30, 2024

wantedsystem Aug 12, 2024

wantedsystem Aug 14, 2024

tmm Jul 30, 2024

wantedsystem Aug 12, 2024

tmm Jul 30, 2024

tmm Jul 30, 2024

tmm Jul 30, 2024

tmm commented Aug 6, 2024

wantedsystem commented Aug 12, 2024

wantedsystem commented Aug 20, 2024

jxom commented Aug 29, 2024

-    ReturnType: LineaEstimateGasReturnType
+    ReturnType: {
+      gasLimit: Hex
+      baseFeePerGas: Hex
+      priorityFeePerGas: Hex
+    }

feat: Add support for linea_estimateGas #2525

feat: Add support for linea_estimateGas #2525

Conversation

wantedsystem commented Jul 23, 2024 • edited by pr-codex bot Loading

PR-Codex overview

Detailed summary

changeset-bot bot commented Jul 23, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Jul 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jxom commented Jul 26, 2024 • edited Loading

wantedsystem commented Jul 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmm commented Aug 6, 2024

wantedsystem commented Aug 12, 2024

wantedsystem commented Aug 20, 2024

jxom commented Aug 29, 2024

wantedsystem commented Jul 23, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Jul 23, 2024 •

edited

Loading

jxom commented Jul 26, 2024 •

edited

Loading