Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: linea #2665

Merged
merged 6 commits into from
Aug 29, 2024
Merged

feat: linea #2665

merged 6 commits into from
Aug 29, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Aug 29, 2024


PR-Codex overview

This PR enhances Linea support by adding gas & fee estimations.

Detailed summary

  • Added built-in support for Linea gas & fee estimations
  • Deprecated chain.fees.defaultPriorityFee
  • Updated chain configurations for Linea Mainnet and Linea Sepolia Testnet
  • Added Linea RPC schema
  • Updated estimate fees per gas functions
  • Updated max priority fee per gas estimation logic
  • Updated package.json to include Linea module
  • Updated estimateFeesPerGas and related functions
  • Added tests for gas estimation and error handling

The following files were skipped due to too many changes: src/linea/chainConfig.test.ts, src/zksync/formatters.test.ts, src/actions/public/estimateMaxPriorityFeePerGas.test.ts, src/linea/actions/estimateGas.ts, src/types/chain.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Aug 29, 2024 0:43am

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 711bb45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 29, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
import * from 'viem' (esm) 60.5 KB (0%) 1.3 s (0%) 3.9 s (+73.27% 🔺) 5.1 s
const viem = require('viem') (cjs) 70.99 KB (0%) 1.5 s (0%) 3.9 s (-24.39% 🔽) 5.3 s
import { createClient, http } from 'viem' 6.22 KB (0%) 125 ms (0%) 97 ms (-62.89% 🔽) 221 ms
import * from 'viem/account-abstraction' 43.78 KB (+0.1% 🔺) 876 ms (+0.1% 🔺) 2.3 s (+33.91% 🔺) 3.1 s
import { toCoinbaseSmartAccount } from 'viem/account-abstraction' 34.01 KB (0%) 681 ms (0%) 2 s (+15.86% 🔺) 2.7 s
import * from 'viem/accounts' 80.17 KB (0%) 1.7 s (0%) 1.2 s (+51.42% 🔺) 2.8 s
import { privateKeyToAccount } from 'viem/accounts' 19.37 KB (0%) 388 ms (0%) 314 ms (-52.65% 🔽) 701 ms
import * from 'viem/actions' 45.94 KB (0%) 919 ms (0%) 1.5 s (-20.54% 🔽) 2.4 s
import { getBlockNumber } from 'viem/actions' 318 B (0%) 10 ms (0%) 19 ms (+167.24% 🔺) 29 ms
import * from 'viem/chains' 36.11 KB (-0.26% 🔽) 723 ms (-0.26% 🔽) 1.4 s (+1.5% 🔺) 2.1 s
import { mainnet } from 'viem/chains' 324 B (0%) 10 ms (0%) 13 ms (-20.38% 🔽) 23 ms
import * from 'viem/chains/utils' 1.08 KB (0%) 22 ms (0%) 17 ms (-73.2% 🔽) 39 ms
import * from 'viem/ens' 45.47 KB (0%) 910 ms (0%) 989 ms (+63.95% 🔺) 1.9 s
import { getEnsAvatar } from 'viem/ens' 22.13 KB (0%) 443 ms (0%) 550 ms (-47.69% 🔽) 992 ms
import * from 'viem/siwe' 30.22 KB (0%) 605 ms (0%) 1.1 s (-3.57% 🔽) 1.7 s
import { verifySiweMessage } from 'viem/siwe' 29.11 KB (0%) 583 ms (0%) 777 ms (+20.96% 🔺) 1.4 s

@jxom jxom merged commit 2e05c52 into main Aug 29, 2024
23 of 26 checks passed
@jxom jxom deleted the feat/linea branch August 29, 2024 00:29
@github-actions github-actions bot mentioned this pull request Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 95.41284% with 10 lines in your changes missing coverage. Please review.

Project coverage is 99.64%. Comparing base (2813fbd) to head (711bb45).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/linea/actions/estimateGas.ts 93.43% 9 Missing ⚠️
src/linea/chainConfig.ts 98.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2665      +/-   ##
==========================================
- Coverage   99.65%   99.64%   -0.01%     
==========================================
  Files         782      785       +3     
  Lines       70570    70775     +205     
  Branches     3285     3297      +12     
==========================================
+ Hits        70326    70524     +198     
- Misses        229      235       +6     
- Partials       15       16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants