Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arrows support for search field #5416

Merged
merged 12 commits into from
Jun 14, 2024
Merged

Add arrows support for search field #5416

merged 12 commits into from
Jun 14, 2024

Conversation

Mrreadiness
Copy link
Contributor

Impliment #3087 (comment)
Add support of cursor and arrows in search field

wez
wez requested changes Jun 12, 2024
View reviewed changes
Copy link
Owner

@wez wez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for diving in, but this is a bit more complex!
Please see my inline comments!

wezterm-gui/src/overlay/copy.rs Outdated Show resolved Hide resolved
wezterm-gui/src/overlay/copy.rs Outdated Show resolved Hide resolved
wezterm-gui/src/overlay/copy.rs Outdated Show resolved Hide resolved
wezterm-gui/src/overlay/copy.rs Outdated Show resolved Hide resolved
wezterm-gui/src/overlay/copy.rs Outdated Show resolved Hide resolved
@kenchou kenchou mentioned this pull request Jun 12, 2024
Closed
@Mrreadiness
Copy link
Contributor Author

Hey guys!
@wez Thanks for the advice. I've added LineEditBuffer.
@kenchou I've also added the Delete key and some other common key bindings.

@Mrreadiness Mrreadiness requested a review from wez June 12, 2024 21:29
@kenchou

This comment was marked as resolved.

Sign in to view
Mrreadiness and others added 2 commits June 13, 2024 11:29
wez
wez reviewed Jun 13, 2024
View reviewed changes
Copy link
Owner

@wez wez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I have two minor suggestions and a question about potentially ambiguous actions!

termwiz/src/lineedit/buffer.rs Outdated Show resolved Hide resolved
wezterm-gui/src/overlay/copy.rs Outdated Show resolved Hide resolved
wezterm-gui/src/overlay/copy.rs Outdated Show resolved Hide resolved
@Mrreadiness Mrreadiness requested a review from wez June 14, 2024 12:43
@kenchou kenchou mentioned this pull request Jun 14, 2024
Merged
@wez wez merged commit 72465af into wez:main Jun 14, 2024
16 of 18 checks passed
@wez
Copy link
Owner

wez commented Jun 14, 2024

Thank you!

wez added a commit that referenced this pull request Jun 14, 2024
@wez
docs: changelog for #5416
ad5d6f9
@kenchou kenchou mentioned this pull request Jun 16, 2024
Open
saep pushed a commit to saep/wezterm that referenced this pull request Jul 14, 2024
@Mrreadiness @kenchou @saep
Add arrows support for search field (wez#5416)
fb60e36 
* feat: add arrows support for search field
* refactor: extract LineEditBuffer from LineEditor
* refactor: migrate search field to LineEditBuffer
* feat: add key bindings for search field

Co-authored-by: Ken Chou <kenchou77@gmail.com>
saep pushed a commit to saep/wezterm that referenced this pull request Jul 14, 2024
@wez @saep
docs: changelog for wez#5416
6e65de7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenchou kenchou kenchou left review comments

@wez wez Awaiting requested review from wez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mrreadiness @kenchou @wez