Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/search field arrows support #5549

Closed
wants to merge 4 commits into from

Conversation

kenchou
Copy link
Contributor

@kenchou kenchou commented Jun 12, 2024

Related PR #5416

Impliment #3087 (comment)

  • Add support of cursor and arrows in search field.
  • Support the [Delete] key to edit the pattern
  • Support unicode.

As a Rust beginner, I'm not sure if there are more convenient existing string handling functions.

@Mrreadiness

@wez
Copy link
Owner

wez commented Jun 12, 2024

Thanks for this; please see my comment in #5416 (comment)
I think that we should refactor and reuse the line editing logic from termwiz for this.

@kenchou
Copy link
Contributor Author

kenchou commented Jun 12, 2024

It's late at night in China, I will continue to study it tomorrow :)

@kenchou
Copy link
Contributor Author

kenchou commented Jun 13, 2024

Closed.
Due to the refactoring in PR #5416, the LineEditBuffer code is now cleaner and more reusable.

@kenchou kenchou closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants