-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: nested browsing context is a member, not a type #5095
Conversation
@domenic might be worth reviewing this as well. |
I'll definitely review this, but I'd like to land the others first, especially because (as seen in #5091 (comment)) I am not 100% up on this space yet, and finishing those will help :). |
<span>top-level browsing context</span>, and its <span>top-level browsing context</span> is <var>B</var>, or</li> | ||
<li>The browsing context <var>A</var> is a <span>child browsing context</span> with a | ||
<span>top-level browsing context</span>, and its <span>top-level browsing context</span> is | ||
<var>B</var>, or</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This goes beyond your current refactoring, but this (and others) bring to light an unfortunate conflation where "child browsing context" is used both as a relation (A is a child browsing context of B) and as a type (A is a child browsing context).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When used as relation it's probably somewhat bogus even as it really depends on the document that's currently the active document in the parent browsing context.
source
Outdated
<p>If the <code>Document</code> is in a <span>nested browsing context</span>, and the | ||
<span>browsing context container</span> of that <span>nested browsing context</span> is a | ||
<p>If the <code>Document</code> is in a <span>child browsing context</span>, and the | ||
<span>browsing context container</span> of that <span>child browsing context</span> is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should xref container. I guess maybe in general we should audit all uses of "browsing context container"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (well, within HTML).
|
Also make more usage of a browsing context's container (document) where possible.
Coupled with other PRs in flight I'm reasonably happy with the end state, but there's room for quibbles, especially around needing to use child browsing context for
object
/embed
sometimes, where nested browsing context is fine for equivalent usage foriframe
/frame
./browsers.html ( diff )
/browsing-the-web.html ( diff )
/history.html ( diff )
/iframe-embed-object.html ( diff )
/input.html ( diff )
/interaction.html ( diff )
/links.html ( diff )
/obsolete.html ( diff )
/origin.html ( diff )
/rendering.html ( diff )
/semantics.html ( diff )
/timers-and-user-prompts.html ( diff )
/urls-and-fetching.html ( diff )
/webstorage.html ( diff )
/window-object.html ( diff )