Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: nested browsing context is a member, not a type #5095

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Nov 18, 2019

Coupled with other PRs in flight I'm reasonably happy with the end state, but there's room for quibbles, especially around needing to use child browsing context for object/embed sometimes, where nested browsing context is fine for equivalent usage for iframe/frame.


/browsers.html ( diff )
/browsing-the-web.html ( diff )
/history.html ( diff )
/iframe-embed-object.html ( diff )
/input.html ( diff )
/interaction.html ( diff )
/links.html ( diff )
/obsolete.html ( diff )
/origin.html ( diff )
/rendering.html ( diff )
/semantics.html ( diff )
/timers-and-user-prompts.html ( diff )
/urls-and-fetching.html ( diff )
/webstorage.html ( diff )
/window-object.html ( diff )

@annevk
Copy link
Member Author

annevk commented Nov 19, 2019

@domenic might be worth reviewing this as well.

@domenic
Copy link
Member

domenic commented Nov 19, 2019

I'll definitely review this, but I'd like to land the others first, especially because (as seen in #5091 (comment)) I am not 100% up on this space yet, and finishing those will help :).

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
<span>top-level browsing context</span>, and its <span>top-level browsing context</span> is <var>B</var>, or</li>
<li>The browsing context <var>A</var> is a <span>child browsing context</span> with a
<span>top-level browsing context</span>, and its <span>top-level browsing context</span> is
<var>B</var>, or</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes beyond your current refactoring, but this (and others) bring to light an unfortunate conflation where "child browsing context" is used both as a relation (A is a child browsing context of B) and as a type (A is a child browsing context).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When used as relation it's probably somewhat bogus even as it really depends on the document that's currently the active document in the parent browsing context.

source Outdated Show resolved Hide resolved
source Outdated
<p>If the <code>Document</code> is in a <span>nested browsing context</span>, and the
<span>browsing context container</span> of that <span>nested browsing context</span> is a
<p>If the <code>Document</code> is in a <span>child browsing context</span>, and the
<span>browsing context container</span> of that <span>child browsing context</span> is a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should xref container. I guess maybe in general we should audit all uses of "browsing context container"

Copy link
Member Author

@annevk annevk Nov 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (well, within HTML).

source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
@annevk
Copy link
Member Author

annevk commented Nov 22, 2019

Editorial: nested browsing context is a member, not a type

Also make more usage of a browsing context's container (document) where possible.

Also make more usage of a browsing context's container (document) where possible.
@annevk annevk merged commit 6b737bb into master Nov 26, 2019
@annevk annevk deleted the annevk/nbc branch November 26, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants