Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: export preload and alternate #5843

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Meta: export preload and alternate #5843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca10eda
Meta: export preload and alternate
horo-t Aug 19, 2020
3e16558
Add data-dfn-for and data-dfn-type
horo-t Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24005,7 +24005,8 @@ document.body.appendChild(wbr);</code></pre>
</table>


<h5 id="rel-alternate">Link type "<dfn><code data-x="rel-alternate">alternate</code></dfn>"</h5>
<h5 id="rel-alternate">Link type "<dfn data-export="" data-dfn-for="link/rel,a/rel,area/rel"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're creating the first external reference, it's a good time to double-check that we have the right data-dfn-type for these keywords. They currently get the default data-dfn-type=dfn, but something like attr-value seems more appropriate. We'd set data-dfn-for to, for example, link/rel,a/rel,area/rel for the link relations that work on several elements.

These also used from https://www.iana.org/assignments/link-relations/link-relations.xhtml to define header parameter values, where attr-value doesn't quite fit, but we could say that's still the <{link/rel/alternate}> form.

Does @tabatkins have any thoughts here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to using data-dfn-for="link/rel,a/rel,area/rel" data-dfn-type="attr-value" here. (And just data-dfn-for="link/rel" data-dfn-type="attr-value" below.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

data-dfn-type="attr-value"><code data-x="rel-alternate">alternate</code></dfn>"</h5>

<p>The <code data-x="rel-alternate">alternate</code> keyword may be used with <code>link</code>,
<code>a</code>, and <code>area</code> elements.</p>
Expand Down Expand Up @@ -24829,7 +24830,8 @@ document.body.appendChild(wbr);</code></pre>
keyword.</p>


<h5>Link type "<dfn><code data-x="rel-preload">preload</code></dfn>"</h5>
<h5>Link type "<dfn data-export="" data-dfn-for="link/rel" data-dfn-type="attr-value"><code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to collide with https://w3c.github.io/preload/#dfn-preload-keyword, but in w3c/preload#154, @domenic suggested moving the canonical definition here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one isn't exported, so it won't be an immediate problem :)

data-x="rel-preload">preload</code></dfn>"</h5>

<p>The <code data-x="rel-preload">preload</code> keyword may be used with <code>link</code>
elements. This keyword creates an <span data-x="external resource link">external resource
Expand Down