-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: export preload and alternate #5843
Conversation
Sorry while I'm writing a patch for WICG/webpackage#591, I noticed that what I want is |
bc796c0
to
ca10eda
Compare
@@ -24829,7 +24830,7 @@ document.body.appendChild(wbr);</code></pre> | |||
keyword.</p> | |||
|
|||
|
|||
<h5>Link type "<dfn><code data-x="rel-preload">preload</code></dfn>"</h5> | |||
<h5>Link type "<dfn data-export=""><code data-x="rel-preload">preload</code></dfn>"</h5> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to collide with https://w3c.github.io/preload/#dfn-preload-keyword, but in w3c/preload#154, @domenic suggested moving the canonical definition here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That one isn't exported, so it won't be an immediate problem :)
@@ -24005,7 +24005,8 @@ document.body.appendChild(wbr);</code></pre> | |||
</table> | |||
|
|||
|
|||
<h5 id="rel-alternate">Link type "<dfn><code data-x="rel-alternate">alternate</code></dfn>"</h5> | |||
<h5 id="rel-alternate">Link type "<dfn data-export=""><code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're creating the first external reference, it's a good time to double-check that we have the right data-dfn-type
for these keywords. They currently get the default data-dfn-type=dfn
, but something like attr-value
seems more appropriate. We'd set data-dfn-for
to, for example, link/rel,a/rel,area/rel
for the link relations that work on several elements.
These also used from https://www.iana.org/assignments/link-relations/link-relations.xhtml to define header parameter values, where attr-value
doesn't quite fit, but we could say that's still the <{link/rel/alternate}>
form.
Does @tabatkins have any thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to using data-dfn-for="link/rel,a/rel,area/rel" data-dfn-type="attr-value"
here. (And just data-dfn-for="link/rel" data-dfn-type="attr-value"
below.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to merge this, but as @jyasskin mentions, let's add more specific annotations while we're here.
@@ -24005,7 +24005,8 @@ document.body.appendChild(wbr);</code></pre> | |||
</table> | |||
|
|||
|
|||
<h5 id="rel-alternate">Link type "<dfn><code data-x="rel-alternate">alternate</code></dfn>"</h5> | |||
<h5 id="rel-alternate">Link type "<dfn data-export=""><code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to using data-dfn-for="link/rel,a/rel,area/rel" data-dfn-type="attr-value"
here. (And just data-dfn-for="link/rel" data-dfn-type="attr-value"
below.)
@@ -24829,7 +24830,7 @@ document.body.appendChild(wbr);</code></pre> | |||
keyword.</p> | |||
|
|||
|
|||
<h5>Link type "<dfn><code data-x="rel-preload">preload</code></dfn>"</h5> | |||
<h5>Link type "<dfn data-export=""><code data-x="rel-preload">preload</code></dfn>"</h5> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That one isn't exported, so it won't be an immediate problem :)
I'd like to reference
preload
andalternate
from "Loading Signed Exchanges" spec.WICG/webpackage#591.
Can I export them?
/links.html ( diff )