Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: export preload and alternate #5843

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

horo-t
Copy link
Contributor

@horo-t horo-t commented Aug 19, 2020

I'd like to reference preload and alternate from "Loading Signed Exchanges" spec.
WICG/webpackage#591.

Can I export them?


/links.html ( diff )

@horo-t horo-t changed the title Meta: export rel and alternate Meta: export preload and alternate Aug 19, 2020
@horo-t
Copy link
Contributor Author

horo-t commented Aug 19, 2020

Sorry while I'm writing a patch for WICG/webpackage#591, I noticed that what I want is preload and alternate.
So I updated the patch to export preload and alternate and changed the title of this pull request.

@horo-t horo-t force-pushed the export_rel_and_alternate branch from bc796c0 to ca10eda Compare August 19, 2020 09:35
@@ -24829,7 +24830,7 @@ document.body.appendChild(wbr);</code></pre>
keyword.</p>


<h5>Link type "<dfn><code data-x="rel-preload">preload</code></dfn>"</h5>
<h5>Link type "<dfn data-export=""><code data-x="rel-preload">preload</code></dfn>"</h5>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to collide with https://w3c.github.io/preload/#dfn-preload-keyword, but in w3c/preload#154, @domenic suggested moving the canonical definition here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one isn't exported, so it won't be an immediate problem :)

@@ -24005,7 +24005,8 @@ document.body.appendChild(wbr);</code></pre>
</table>


<h5 id="rel-alternate">Link type "<dfn><code data-x="rel-alternate">alternate</code></dfn>"</h5>
<h5 id="rel-alternate">Link type "<dfn data-export=""><code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're creating the first external reference, it's a good time to double-check that we have the right data-dfn-type for these keywords. They currently get the default data-dfn-type=dfn, but something like attr-value seems more appropriate. We'd set data-dfn-for to, for example, link/rel,a/rel,area/rel for the link relations that work on several elements.

These also used from https://www.iana.org/assignments/link-relations/link-relations.xhtml to define header parameter values, where attr-value doesn't quite fit, but we could say that's still the <{link/rel/alternate}> form.

Does @tabatkins have any thoughts here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to using data-dfn-for="link/rel,a/rel,area/rel" data-dfn-type="attr-value" here. (And just data-dfn-for="link/rel" data-dfn-type="attr-value" below.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this, but as @jyasskin mentions, let's add more specific annotations while we're here.

@@ -24005,7 +24005,8 @@ document.body.appendChild(wbr);</code></pre>
</table>


<h5 id="rel-alternate">Link type "<dfn><code data-x="rel-alternate">alternate</code></dfn>"</h5>
<h5 id="rel-alternate">Link type "<dfn data-export=""><code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to using data-dfn-for="link/rel,a/rel,area/rel" data-dfn-type="attr-value" here. (And just data-dfn-for="link/rel" data-dfn-type="attr-value" below.)

@@ -24829,7 +24830,7 @@ document.body.appendChild(wbr);</code></pre>
keyword.</p>


<h5>Link type "<dfn><code data-x="rel-preload">preload</code></dfn>"</h5>
<h5>Link type "<dfn data-export=""><code data-x="rel-preload">preload</code></dfn>"</h5>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one isn't exported, so it won't be an immediate problem :)

@horo-t horo-t requested a review from domenic August 19, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants