Fix closed getter note (fixes #912) #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakearchibald
suggested changes
Mar 28, 2018
There was a problem hiding this comment.
https://streams.spec.whatwg.org/#byob-reader-prototype needs to be updated too.
index.bs
Outdated
| reader's lock is <a lt="release a read lock">released</a>, or rejected if the stream ever errors. | ||
| The <code>closed</code> getter returns a promise that will be fulfilled when the stream becomes closed, or rejected if | ||
| the stream ever errors or the reader's lock is <a lt="release a read lock">released</a> before the stream finishes | ||
| closing or the stream errors. |
There was a problem hiding this comment.
or the stream errors.
I don't think you need to say this, as you've already made it clear that the promise rejects on error.
index.bs
Outdated
| @@ -3531,7 +3533,7 @@ lt="WritableStreamDefaultWriter(stream)">new WritableStreamDefaultWriter(<var>st | |||
| <div class="note"> | |||
| The <code>closed</code> getter returns a promise that will be fulfilled when the stream becomes closed, or rejected if | |||
| the stream ever errors or the writer's lock is <a lt="release a write lock">released</a> before the stream finishes | |||
| closing. | |||
| closing or the stream errors. | |||
surma
changed the title
jakearchibald
approved these changes
Mar 28, 2018
|
Travis CI doesn't seem to be happy. Since this isn't urgent, I (or someone else) can merge it once Travis CI is feeling better. |
|
I re-pushed my last commit to restart Travis. Seems like it worked :) |
This was referenced Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took some inspiration from the writer’s
closedgetter :)Preview | Diff