fixes for github actions #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-heusel
added a commit
to christian-heusel/mediawiki-docker
that referenced
this pull request
Oct 16, 2023
This fixes an error that was not caught by local testing in wikimedia#132: > must be run from inside a git repository > Error: Process completed with exit code 1. This is maybe just a workaround for a bug in the checkout action, which already should set the correct safe directory according to its documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the update action fails (see https://github.com/wikimedia/mediawiki-docker/actions/runs/6345587761/job/17237820236#step:4:55) because of an invalid cert. According to google/go-github#1049 this is most likely caused by missing ca-certificates which this PR also installs in the pipeline.
While we are at it this also updates the readme to correctly reflect the current state of things, reformats the yaml a bit and updates the checkout action. 😊
This was locally tested to fix the issue using https://github.com/nektos/act/