Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly set the git safe directory #135

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

christian-heusel
Copy link
Collaborator

@christian-heusel christian-heusel commented Oct 16, 2023

This fixes an error that was not caught by local testing in #132:

must be run from inside a git repository
Error: Process completed with exit code 1.

The error can be observed in the scheduled pipeline runs: https://github.com/wikimedia/mediawiki-docker/actions/runs/6527365499/job/17722124059#step:5:10

This is maybe just a workaround for a bug in the checkout action, which
already should set the correct safe directory according to its
documentation.

This was verified to run and fix the problem here which ran a slightly modified version of this patch for testing purposes (christian-heusel@3f451d2).

This fixes an error that was not caught by local testing in wikimedia#132:
> must be run from inside a git repository
> Error: Process completed with exit code 1.

This is maybe just a workaround for a bug in the checkout action, which
already should set the correct safe directory according to its
documentation.
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@legoktm legoktm merged commit 8933072 into wikimedia:main Oct 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants