[WFLY-17678] Add Micrometer quickstart

[jasondlee]

https://issues.redhat.com/browse/WFLY-17678

Add module
Develop demo app
Add README

[emmartins]

Some changes needed, some changes suggested and there are a couple resources missing:

1. the Helm Chart at charts/helm.yaml (see https://docs.google.com/document/d/1GFnZrnlwRkwC0HfziRws2UUWR99KdaQayA7Ei12SGN4/edit#heading=h.sldbnukpvc2 )
2. the CI workflow at .github/workflows/quickstart_microprofile-micrometer_ci.yml ( see https://docs.google.com/document/d/1GFnZrnlwRkwC0HfziRws2UUWR99KdaQayA7Ei12SGN4/edit#heading=h.c4iuyi3bm84h )

[emmartins]

Following the README instructions it's failing to deploy on current WFLY main (dist/target/wildfly-30.0.0.Final-SNAPSHOT/bin/standalone.sh), perhaps it needs another config? If so you should specify which in the README.adoc attributes at top

[emmartins]

Following the README instructions it's failing to deploy on current WFLY main (dist/target/wildfly-30.0.0.Final-SNAPSHOT/bin/standalone.sh), perhaps it needs another config? If so you should specify which in the README.adoc attributes at top

Ok it seems this is just a README issue, later in the doc it's required to reconfig the server, I will pinpoint in sources...

[jasondlee]

@emmartins Changes made and pushed.

[kabir]

/retest

[emmartins]

Please rebase and do changes on comments.

[jasondlee]

@emmartins I believe I have addressed all of the requests here. Please verify and let me know if I missed anything. On to the next one... :)

[emmartins]

Everything looks good, but functionally the docker service is not working as expected with bootable-jar and provisioned-server, I believe this is due to not configuring the micrometer endpoint, which can be solved by packaging a cli script with the following command:

/subsystem=micrometer:write-attribute(name=endpoint, value="http://localhost:4318/v1/metrics")

Now thinking a bit more about this, I can imagine this kind of design will have trouble on OpenShift too, cause we need similar script packaged on openshift profile yet we don't actually know the metrics service hostname. Related, I guess we also need extra README content on how to setup the metrics service for OpenShift. Alternatively, we could say there that setup and usage of the metrics service is not OpenShift compatible, that only the app is compatible, but I think that would make us look as lazy.

[emmartins]

Everything looks good, but functionally the docker service is not working as expected with bootable-jar and provisioned-server, I believe this is due to not configuring the micrometer endpoint, which can be solved by packaging a cli script with the following command:

/subsystem=micrometer:write-attribute(name=endpoint, value="http://localhost:4318/v1/metrics")

Now thinking a bit more about this, I can imagine this kind of design will have trouble on OpenShift too, cause we need similar script packaged on openshift profile yet we don't actually know the metrics service hostname. Related, I guess we also need extra README content on how to setup the metrics service for OpenShift. Alternatively, we could say there that setup and usage of the metrics service is not OpenShift compatible, that only the app is compatible, but I think that would make us look as lazy.

Wrt packaging a script to do such change, you can use same approach as the telemetry one, and change configure-micrometer.cli to be

# CLI script to enable micrometer for the quickstart application in the application server
if (outcome != success) of /extension=org.wildfly.extension.micrometer:read-resource
    /extension=org.wildfly.extension.micrometer:add()
    /subsystem=micrometer:add()
end-if

# Configure the endpoint for metrics publication
/subsystem=micrometer:write-attribute(name=endpoint, value="http://localhost:4318/v1/metrics")

and then you package it to the wiildfly and wildfly-jar plugin configs:

                            <!-- use cli script(s) to configure the server -->
                            <packaging-scripts>
                                <packaging-script>
                                    <scripts>
                                        <script>${basedir}/configure-micrometer.cli</script>
                                    </scripts>
                                </packaging-script>
                            </packaging-scripts>

This still has the OpenShift trouble of the localhost hostname usage in the script tho.

PS: please note the removal of reload command, such command atm has issues with provisioning so please remove it from all scripts (valid for telemetry script too)

[emmartins]

provisioned-server and bootable-jar now works, thanks.

[emmartins]

WFLY 31.0.0.Beta1 has been released, please rebase this PR with upstream/main branch, and update:

• All pom.xml to 31.0.0.Final-SNAPSHOT
• All pom.xml to 6
• Property named version.server to 31.0.0.Beta1
• Property named version.plugin.wildfly to 4.2.1.Final

[emmartins]

LGTM now, @kstekovi you good to go on this one too

[openshift-ci]

@jasondlee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/wildfly-quickstart-e2e	a5d9418	link	true	/test wildfly-quickstart-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[emmartins]

Tested baremetal and provisioning locally, LGTM.

[kstekovi]

everything LGTM. I don't have any topics for discussion.

The OpenShift part is not ready yet.

[emmartins]

merged, thank you both, please don't forget we now should work on a new PR properly handling OpenShift