[WFLY-19450] mail Quickstarts should have a root webpage similar to helloworld #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iweiss
reviewed
Jun 25, 2024
|
|
||
| public class TestUtils { | ||
| static final String DEFAULT_SERVER_HOST = "http://localhost:8080/mail"; | ||
| static final String API_PATH = "/home.jsf"; |
There was a problem hiding this comment.
I think this variable could be renamed to something more descriptive, for example HOME_PATH or MAINPAGE_PATH.
There was a problem hiding this comment.
refactored the code changes.
iweiss
reviewed
Jun 25, 2024
| if (serverHost == null) { | ||
| serverHost = DEFAULT_SERVER_HOST; | ||
| } | ||
| HttpGet httpGet = new HttpGet(getServerHost()); |
There was a problem hiding this comment.
What the purpose of this object? I don't see it being used elsewhere.
|
With the changes on this PR, I don't see the point of keeping |
yersan
previously approved these changes
Jul 4, 2024
yersan
dismissed
their stale review
Now I noticed it is pending remove an unused constant
yersan
requested changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFLY-19450
Linked Issue: https://issues.redhat.com/browse/WFLY-19075