[WFLY-19465] spring-resteasy Quickstarts should have a root webpage similar to helloworld #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Kubernetes' test failures look to be related to the same changes you made on #937. |
Yes, I have noticed it. Refactored the code accordingly. |
iweiss
reviewed
Jun 27, 2024
| @@ -50,17 +50,18 @@ public class HelloSpringResource { | |||
| @Produces("text/html") | |||
| public Response getDefault(@Context UriInfo uriInfo) { | |||
| String baseURI = uriInfo.getBaseUri().toString(); | |||
| baseURI = baseURI + "main"; | |||
There was a problem hiding this comment.
I think this line goes below the if() statement and it seems it should contain / at the end of main.
There was a problem hiding this comment.
made the changes. thanks.
…milar to helloworld
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFLY-19465
Linked Issue: https://issues.redhat.com/browse/WFLY-19075