Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#258 Symfony 4.2 tree builder depreciation error #259

Closed
wants to merge 1 commit into from
Closed

#258 Symfony 4.2 tree builder depreciation error #259

wants to merge 1 commit into from

Conversation

steveWinter
Copy link

@steveWinter steveWinter commented Jan 4, 2019

Addressing #258

@steveWinter
Copy link
Author

Open to suggestions as to what to do about the Travis failures

  • for PHP > 7 this is being caused by another Symfony 4.2 deprecation - I'm happy to address this, but would prefer to do so in another PR at a later time
  • for PHP < 7 composer require is running out of memory (and given eol of 5.6 is it even necessary to support this any longer?)

@monteiro
Copy link
Collaborator

monteiro commented Feb 4, 2019

I've created the issue: #261 to get a response from the community about this.

Thanks for the contribution!

@ping-localhost
Copy link

Is there anything I can do to get this merged @monteiro?

@stof
Copy link
Contributor

stof commented May 7, 2019

composer running out of memory is not for PHP < 7 but for jobs customizing the constraints. The fact that they run PHP 5.6 is not the cause of the issue (we also have green jobs with PHP 5.6). So dropping support for PHP 5.6 is not the solution.

The deprecation for jobs running PHP 7 (and so installing Symfony 4) is because of the testsuite itself relying on a deprecated feature. That could indeed be solved separately.

And there is another uninvestigated failure: the PHP 5.4 job getting the wrong data (maybe this is related to using Symfony 2.8 in it rather than Symfony 3)

@steveWinter
Copy link
Author

It seems #263 is also attempting to do the same and gaining more traction so I'm going to close this.

@steveWinter steveWinter closed this Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants