Symfony 4.2 depreciation fixes #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
May 29, 2019 17:31
|
@romantymoshyk thanks a lot for the PR, can you remove anything related with Travis configurations? No worries if the tests fail at the moment. The most important is to support the latest versions of symfony. |
monteiro
reviewed
Dec 3, 2019
| @@ -70,6 +75,10 @@ public function registerContainerConfiguration(LoaderInterface $loader) | |||
| if (self::VERSION_ID > 30200) { | |||
| $loader->load(__DIR__.'/config/disable_annotations.yml'); | |||
| } | |||
|
|
|||
| if (self::VERSION_ID < 40200 && file_exists(__DIR__.'/Resources/translations') === false) { | |||
| self::recurseCopy(__DIR__.'/../translations', __DIR__.'/Resources/translations'); | |||
There was a problem hiding this comment.
@stof want ask your help. Is this the correct way to do it? Doing a recursive copy? Thanks for the help!
There was a problem hiding this comment.
@monteiro, that was written as in SF4.2 was changed default directory structure. If SF will not found translations in new expected place it will throw deprecation message in SF4.2 and fail in SF5.
… 4.2" This reverts commit 32a4628.
|
@monteiro , .travis.yml changes were reverted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request apply fixes to: