Coverity: fix WPrefs workspace negative array index read

window-maker · Mar 3, 2023 · d4ee17f · d4ee17f
1 parent 7475bc5
commit d4ee17f
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/WPrefs.app/Workspace.c b/WPrefs.app/Workspace.c
@@ -207,12 +207,15 @@ static void createPanel(Panel * p)
 
 static void storeData(_Panel * panel)
 {
+	int tmp = WMGetPopUpButtonSelectedItem(panel->posP);
+
+	if (tmp < 0)
+		return;
 	SetBoolForKey(!WMGetButtonSelected(panel->linkB), "DontLinkWorkspaces");
 	SetBoolForKey(WMGetButtonSelected(panel->cyclB), "CycleWorkspaces");
 	SetBoolForKey(WMGetButtonSelected(panel->newB), "AdvanceToNewWorkspace");
 
-	SetStringForKey(WSNamePositions[WMGetPopUpButtonSelectedItem(panel->posP)],
-			"WorkspaceNameDisplayPosition");
+	SetStringForKey(WSNamePositions[tmp], "WorkspaceNameDisplayPosition");
 }
 
 Panel *InitWorkspace(WMWidget *parent)