-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate examples to type: module
#4662
Conversation
🦋 Changeset detectedLatest commit: ddf7c39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
We agreed to move forward with this but rollback the change from |
Thanks for waiting @natemoo-re! I’ve opened withastro/docs#1514 to make the necessary docs changes. I’d also like to change one line in the Tailwind integration README:
Want to update that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of that docs change!
ce6be71
to
bc733fa
Compare
Changes
"type": "module"
in theirpackage.json
files.vite
startersastro.config.js
instead of the defensiveastro.config.mjs
Testing
Manually
Docs
/cc @withastro/maintainers-docs for feedback!
We'd likely want to pair this change with a change to our docs to recommend
astro.config.js
with"type": "module"
in thepackage.json
file.