Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates to prepare for examples using "type": "module" #1514

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

delucis
Copy link
Member

@delucis delucis commented Sep 9, 2022

What kind of changes does this PR include?

  • New or updated content

Description

  • Two small content tweaks to support Migrate examples to type: module astro#4662
  • We still mention one Common JS file that uses .js in the Layer0 deploy guide, but this seems to be a file their CLI creates, so I’ve left that as is. Let’s see if we get any bug reports.
  • There’s also a line that needs changing in the Tailwind integration README. Going to request that happen as part of @natemoo-re’s astro PR.

@netlify
Copy link

netlify bot commented Sep 9, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 3d81825
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/631b3430f8086a000b245d3b
😎 Deploy Preview https://deploy-preview-1514--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@delucis delucis changed the title Small content updates to prepare for defaulting to "type": "module" Small updates to prepare for examples using "type": "module" Sep 9, 2022
@delucis delucis merged commit 319b1f5 into main Sep 9, 2022
@delucis delucis deleted the chris/module-changes branch September 9, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants