Fallback to tap prefetch strategy on slow connection #9092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d0938b4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
github-actions
bot
added
the
pr: docs
bluwy
reviewed
Nov 14, 2023
bluwy
approved these changes
Nov 15, 2023
sarah11918
reviewed
Nov 21, 2023
sarah11918
approved these changes
Nov 21, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Merged
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
tapprefetch strategy on slow connection, instead of bailing.ignoreSlowConnectionoption to prefetch API, which lets manually prefetch even on data saver mode or slow connection.Testing
Tested on test cases added in this PR #8951
Docs
Docs: withastro/docs#5393
This PR also has changesets and JSDoc for review.