Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: prefetch tap fallback on slow connection and ignore slow connection option #5393

Merged
merged 6 commits into from
Nov 22, 2023
Merged

docs: prefetch tap fallback on slow connection and ignore slow connection option #5393

merged 6 commits into from
Nov 22, 2023

Conversation

0xtimsb
Copy link
Contributor

@0xtimsb 0xtimsb commented Nov 13, 2023

Add docs for:

  1. Fallback to tap prefetch strategy on slow connection, instead of bailing.
  2. ignoreSlowConnection option to prefetch API, which lets manually prefetch even on data saver mode or slow connection.

See astro PR #9092.

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ef578b4
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/655291b334c9d20008996d62
😎 Deploy Preview https://deploy-preview-5393--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@0xtimsb 0xtimsb mentioned this pull request Nov 13, 2023
Merged
astrobot-houston
astrobot-houston reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@astrobot-houston astrobot-houston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918 sarah11918 added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Nov 13, 2023
bluwy
bluwy approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording nits, but it describes the feature from the core PR well 👍

src/content/docs/en/guides/prefetch.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/prefetch.mdx Outdated Show resolved Hide resolved
@sarah11918 @bluwy
Apply suggestions from Bjorn code review
1605b7c 
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@vercel Vercel
Copy link

vercel bot commented Nov 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 22, 2023 2:29pm

@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Nov 17, 2023
sarah11918
sarah11918 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution, @smitbarmase ! The docs look good, and these will be added to the next minor release. Welcome to Team Docs! 🥳

@sarah11918
Copy link
Member

Just updating branch to get a Vercel deploy preview

@sarah11918 sarah11918 merged commit e55df27 into withastro:main Nov 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@bluwy bluwy bluwy approved these changes

@astrobot-houston astrobot-houston astrobot-houston left review comments

Assignees
No one assigned
Labels
merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xtimsb @sarah11918 @bluwy @astrobot-houston