iOS: perform actions on UIPickerView #605

DmitryPonomarenko · 2018-03-06T14:19:43Z

Add test screen with pickerView(iOS)
Add tests to e2e folder for this pickerView

LeoNatan · 2018-03-06T14:24:21Z

detox/test/e2e/p-datePicker.js

+    });
+
+    it('check and scroll datePicker', async () => {
+        await expect(element(by.type('UIPickerView'))).toBeVisible();


Why by type and not by id? Does it not work?

UIPickerView have not accessibility ID, testID = {'CustomDatePicker'} need to be deleted

This is a problem. If user has more than one pickers, the API will break

UIPickerView is a UIView, so it can have an accessibility ID. Are you seeing that UIDatePicker does not forward that ID?

I checked that UI element via AccessebilityInspector (from Xcode Instruments), and now I found only one way to get element by type

It won't work on android

We know. We want to hone down iOS support first, then we will implement Android as well.

LeoNatan · 2018-03-06T14:26:25Z

detox/test/ios/example.xcodeproj/project.pbxproj

@@ -491,10 +519,14 @@
 				39A34C5D1E30ED3600BEBB59 /* libcxxreact.a */,
 				39A34C5F1E30ED3600BEBB59 /* libjschelpers.a */,
 				39A34C611E30ED3600BEBB59 /* libjschelpers.a */,
+				D58447B0204E9C6000248543 /* libjsinspector.a */,


What is this? What will happen if old RN is used? In CI, we have an RN matrix that changes RN versions on the fly. Currently we are testing RN 51 and 53.3

LeoNatan · 2018-03-06T14:27:07Z

detox/test/src/Screens/DatePickerScreen.js

+  render() {
+    return (
+      <View style={{flex: 1, paddingTop: 20, justifyContent: 'center', alignItems: 'center'}}>
+        <DatePickerIOS testID = {'CustomDatePicker'}


If there is testID why find by type in the test?

UIPickerView have not accessibility ID, testID = {'CustomDatePicker'} need to be deleted

LeoNatan · 2018-03-06T14:31:22Z

In the future, please do not open new PRs, just push in to previous.

From the previous PR discussion:

Android implementation needs to have a different API. We can not use same API for both, Android has only date or time pickers, iOS has date, time and datetime pickers, therefore:
iOS API should use setColumnToValue
Android API should use setToDate(y, m, d) and setToTime(h, m)

Android resources:
DatePicker
TimePicker
Espresso API:
PickerActions
Example

LeoNatan · 2018-03-06T14:38:16Z

You are missing the docs/APIRef.ActionsOnElement.md information in this PR. Previous PR had the update there.

LeoNatan · 2018-03-06T14:48:04Z

detox/test/e2e/p-datePicker.js

+    it('check and scroll datePicker', async () => {
+        await expect(element(by.type('UIPickerView'))).toBeVisible();
+        await expect(element(by.type('UIPickerView')).setColumnToValue(1,"6"));
+        await expect(element(by.type('UIPickerView')).setColumnToValue(2,"34"));


Expect should not be on actions.
You should have a label and see that the correct value is shown there.

Should be something like

await element(by.type('UIPickerView')).setColumnToValue(2,"34"); await expect(element(by.id('time'))).toHaveText('6:34');

timsawtell-sportsbet · 2018-03-06T22:42:19Z

I was working on a PR of my own to fix this issue and should have checked here first! Very keen to see this enhancement get in, as it's a blocker for our tests at the moment.

Would it be possible to get this merged with support for iOS only? I notice the implementation for Android is missing, and I myself haven't attempted to implement the Android version because we're not using it. Surely motivated Android devs could implement the [equivalent to] GreyAction for Android should they have a desire to get it working. crosses fingers

LeoNatan · 2018-03-07T06:12:38Z

@timsawtell-sportsbet We discusses this internally and finallly decided we will merge it before the Android support lands. Once the PR is satisfactory (very soon), we will merge.

LeoNatan · 2018-03-12T16:14:36Z

Why is this stale for so long? @DmitryPonomarenko
Now there are conflicts in the branch. Please merge mast first and then make the changes as needed.

# Conflicts: # detox/test/ios/example.xcodeproj/project.pbxproj # detox/test/ios/example/Info.plist # detox/test/src/Screens/index.js # detox/test/src/app.js

LeoNatan

The tests are failing. Please check why and fix where needed.

LeoNatan · 2018-03-13T16:07:50Z

generation/package.json

What changed in this file? If nothing, please revert this file.

This still remains open. Why did the file change?

LeoNatan · 2018-03-13T16:08:26Z

docs/APIRef.ActionsOnElement.md

@@ -107,3 +108,13 @@ await element(by.id('scrollView')).swipe('down');
 await element(by.id('scrollView')).swipe('down', 'fast');
 await element(by.id('scrollView')).swipe('down', 'fast', 0.5);
 ```
+### `setColumnToValue(column,value)`


This should be explicitly marked as iOS only in the documentation.

LeoNatan · 2018-03-13T16:09:02Z

detox/test/ios/example.xcodeproj/project.pbxproj

@@ -1145,7 +1201,7 @@
 					"-ObjC",
 					"-lc++",
 				);
-				PRODUCT_BUNDLE_IDENTIFIER = "org.reactjs.native.example.$(PRODUCT_NAME:rfc1034identifier)";
+				PRODUCT_BUNDLE_IDENTIFIER = org.reactjs.native.example.example;


Why is this change necessary?

LeoNatan · 2018-03-13T16:09:24Z

detox/test/e2e/p-datePicker.js

+    });
+
+    it('check and scroll datePicker', async () => {
+        await expect(element(by.type('UIPickerView'))).toBeVisible();


This test should be wrapped with if(iOS).

LeoNatan · 2018-03-13T16:10:24Z

detox/test/e2e/p-datePicker.js

+    it('check and scroll datePicker', async () => {
+        await expect(element(by.type('UIPickerView'))).toBeVisible();
+        await element(by.type('UIPickerView')).setColumnToValue(1,"6");
+        await element(by.type('UIPickerView')).setColumnToValue(2,"34");


Right now, this test checks nothing. There should be a label in the screen, and on date picker change value, it should update. You should then assert that the label has the correct value.

Checking label with text will be always true, because this label always on date picker, I think right solution is checking property of datePicker current value or something like that, now I work in this direction, add this functionality asap

I don't understand. The label is updated with the value set in the picker. So if you select 6:41, it won't say "6:34" in the label. If you assert that label.text == "6:34", you will test that the picker really changed value. That's what we want to test in the testing suite.

In my example if element (UIPickerView) can't find variable with current column or value test will be failed

But that is not what we test in the suite. We test that the native system behaves as expected following Detox changes.

LeoNatan · 2018-03-14T14:55:12Z

As we discussed, also please test if Earl Grey has API to assert on the picker value at column.

LeoNatan · 2018-03-14T16:28:48Z

detox/test/e2e/s-datePicker.js

+      await element(by.text('DatePicker')).tap();
+    });
+
+    it('datePicker and dateLabel should be visible', async () => {


This is not necessary.

LeoNatan · 2018-03-20T13:14:00Z

detox/test/ios/example.xcodeproj/project.pbxproj

@@ -1137,15 +1137,15 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				DEAD_CODE_STRIPPING = NO;
-				DEVELOPMENT_TEAM = "";
+				DEVELOPMENT_TEAM = S3GLW74Y8N;


I don't understand why these changes are going in?
Please revert it. The entire project,pbxproj file changes seem to me like something that should not have been committed.

LeoNatan · 2018-03-20T13:16:02Z

generation/package.json

This still remains open. Why did the file change?

Implement functionality for changing the column values of pickers on IOS

DmitryPonomarenko added 2 commits March 6, 2018 16:15

functionality for datePicker IOS

f708294

current work

41e6034

DmitryPonomarenko requested a review from rotemmiz as a code owner March 6, 2018 14:19

LeoNatan reviewed Mar 6, 2018

View reviewed changes

add setColumnToValue method

2eaabda

delete testID

1b7cb17

LeoNatan suggested changes Mar 6, 2018

View reviewed changes

LeoNatan mentioned this pull request Mar 7, 2018

[Question] Select picker #139

Closed

DmitryPonomarenko added 3 commits March 13, 2018 09:07

Merge branch 'master' into FunctionalityForTestingPickerIOS

79bf393

# Conflicts: # detox/test/ios/example.xcodeproj/project.pbxproj # detox/test/ios/example/Info.plist # detox/test/src/Screens/index.js # detox/test/src/app.js

add description for ActionsOnElement, delete expect for action

1a4d56f

Merge branch 'master' into FunctionalityForTestingPickerIOS

363bc2b

LeoNatan suggested changes Mar 13, 2018

View reviewed changes

DmitryPonomarenko added 2 commits March 14, 2018 18:19

add checking data after scrolling datePicker

bd01ad0

updates

e9a7abe

LeoNatan suggested changes Mar 14, 2018

View reviewed changes

DmitryPonomarenko added 2 commits March 20, 2018 15:09

changes

cb87e43

Merge branch 'master' into FunctionalityForTestingPickerIOS

604b1ff

LeoNatan suggested changes Mar 20, 2018

View reviewed changes

DmitryPonomarenko and others added 6 commits March 20, 2018 15:42

delete team

b6db95d

Update s-datePicker.js

ae1d48e

Discard changes in this file

02526c9

unit tests

0a9d71d

test new functionality

46c5702

Merge branch 'master' into FunctionalityForTestingPickerIOS

073140e

DmitryPonomarenko and others added 4 commits March 26, 2018 11:18

Merge branch 'master' into FunctionalityForTestingPickerIOS

98d3eb7

fixed unit test

087d2ba

Update APIRef.ActionsOnElement.md

a22bbeb

Update APIRef.ActionsOnElement.md

6770cd4

LeoNatan approved these changes Mar 26, 2018

View reviewed changes

LeoNatan merged commit 702597b into master Mar 26, 2018

LeoNatan deleted the FunctionalityForTestingPickerIOS branch March 26, 2018 12:41

rotemmiz changed the title ~~Functionality for testing picker ios~~ IOS: perform actions on UIPickerView Mar 26, 2018

rotemmiz changed the title ~~IOS: perform actions on UIPickerView~~ iOS: perform actions on UIPickerView Mar 26, 2018

yershalom pushed a commit that referenced this pull request Apr 4, 2018

Functionality for testing picker ios (#605)

7b4a2f0

Implement functionality for changing the column values of pickers on IOS

wix locked and limited conversation to collaborators Jul 23, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

iOS: perform actions on UIPickerView #605

iOS: perform actions on UIPickerView #605

DmitryPonomarenko commented Mar 6, 2018

LeoNatan Mar 6, 2018

DmitryPonomarenko Mar 6, 2018

LeoNatan Mar 6, 2018

LeoNatan Mar 6, 2018

DmitryPonomarenko Mar 6, 2018 •

edited

Loading

LeoNatan Mar 6, 2018

skv-headless Mar 13, 2018

LeoNatan Mar 13, 2018

LeoNatan Mar 6, 2018

LeoNatan Mar 6, 2018

DmitryPonomarenko Mar 6, 2018

LeoNatan commented Mar 6, 2018 •

edited

Loading

LeoNatan commented Mar 6, 2018 •

edited

Loading

LeoNatan Mar 6, 2018

timsawtell-sportsbet commented Mar 6, 2018 •

edited

Loading

LeoNatan commented Mar 7, 2018

LeoNatan commented Mar 12, 2018

LeoNatan left a comment

LeoNatan Mar 13, 2018

LeoNatan Mar 20, 2018

LeoNatan Mar 13, 2018

LeoNatan Mar 13, 2018

LeoNatan Mar 13, 2018

LeoNatan Mar 13, 2018

DmitryPonomarenko Mar 13, 2018

LeoNatan Mar 13, 2018

DmitryPonomarenko Mar 13, 2018

LeoNatan Mar 13, 2018

LeoNatan commented Mar 14, 2018

LeoNatan Mar 14, 2018

LeoNatan Mar 20, 2018

LeoNatan Mar 20, 2018

iOS: perform actions on UIPickerView #605

iOS: perform actions on UIPickerView #605

Conversation

DmitryPonomarenko commented Mar 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DmitryPonomarenko Mar 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LeoNatan commented Mar 6, 2018 • edited Loading

LeoNatan commented Mar 6, 2018 • edited Loading

Choose a reason for hiding this comment

timsawtell-sportsbet commented Mar 6, 2018 • edited Loading

LeoNatan commented Mar 7, 2018

LeoNatan commented Mar 12, 2018

LeoNatan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LeoNatan commented Mar 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DmitryPonomarenko Mar 6, 2018 •

edited

Loading

LeoNatan commented Mar 6, 2018 •

edited

Loading

LeoNatan commented Mar 6, 2018 •

edited

Loading

timsawtell-sportsbet commented Mar 6, 2018 •

edited

Loading