iOS: perform actions on UIPickerView #605
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| { | ||
| "eslint.enable": false, | ||
| "git.ignoreLimitWarning": true | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| describe('DatePicker', () => { | ||
| beforeEach(async () => { | ||
| await device.reloadReactNative(); | ||
| }); | ||
|
|
||
| beforeEach(async () => { | ||
| await element(by.text('DatePicker')).tap(); | ||
| }); | ||
|
|
||
| it('check and scroll datePicker', async () => { | ||
| await expect(element(by.type('UIPickerView'))).toBeVisible(); | ||
|
There was a problem hiding this comment. This test should be wrapped with |
||
| await element(by.type('UIPickerView')).setColumnToValue(1,"6"); | ||
| await element(by.type('UIPickerView')).setColumnToValue(2,"34"); | ||
|
There was a problem hiding this comment. Right now, this test checks nothing. There should be a label in the screen, and on date picker change value, it should update. You should then assert that the label has the correct value. There was a problem hiding this comment. Checking label with text will be always true, because this label always on date picker, I think right solution is checking property of datePicker current value or something like that, now I work in this direction, add this functionality asap There was a problem hiding this comment. I don't understand. The label is updated with the value set in the picker. So if you select 6:41, it won't say "6:34" in the label. If you assert that There was a problem hiding this comment. In my example if element (UIPickerView) can't find variable with current column or value test will be failed There was a problem hiding this comment. But that is not what we test in the suite. We test that the native system behaves as expected following Detox changes. |
||
| }); | ||
|
|
||
| }); | ||
|
|
||
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import React, { Component } from 'react'; | ||
| import { | ||
| Text, | ||
| View, | ||
| StyleSheet, | ||
| DatePickerIOS | ||
| } from 'react-native'; | ||
|
|
||
| export default class DatePickerScreen extends Component { | ||
|
|
||
| constructor(props) { | ||
| super(props); | ||
| } | ||
|
|
||
| render() { | ||
| return ( | ||
| <View style={{flex: 1, paddingTop: 20, justifyContent: 'center', alignItems: 'center'}}> | ||
| <DatePickerIOS | ||
| style = {styles.datePicker} | ||
| date = {new Date()} | ||
| /> | ||
| </View> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| const styles = StyleSheet.create({ | ||
| datePicker: { | ||
| width:'100%', | ||
| height:200, | ||
| backgroundColor:'green', | ||
| } | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,52 +1,47 @@ | ||
| { | ||
| "name": "generation", | ||
|
There was a problem hiding this comment. What changed in this file? If nothing, please revert this file. There was a problem hiding this comment. This still remains open. Why did the file change? |
||
| "version": "0.0.1", | ||
| "description": "Generate wrapper code for native dependencies", | ||
| "main": "index.js", | ||
| "private": true, | ||
| "scripts": { | ||
| "build": "./index.js", | ||
| "test": "jest", | ||
| "precommit": "lint-staged", | ||
| "format": "prettier ./**/*.{js,json,css,md} --write" | ||
| }, | ||
| "author": "DanielMSchmidt <danielmschmidt92@gmail.com>", | ||
| "license": "MIT", | ||
| "lint-staged": { | ||
| "*.{js,json,css,md}": ["prettier --write", "git add"] | ||
| }, | ||
| "devDependencies": { | ||
| "babel-generator": "^6.25.0", | ||
| "babel-types": "^6.25.0", | ||
| "download-file-sync": "^1.0.4", | ||
| "jest": "^20.0.4", | ||
| "lerna": "2.0.0-rc.4", | ||
| "lint-staged": "^6.0.0", | ||
| "objective-c-parser": "1.1.0", | ||
| "prettier": "^1.8.2", | ||
| "remove": "^0.1.5" | ||
| }, | ||
| "jest": { | ||
| "coveragePathIgnorePatterns": ["<rootDir>/index.js"], | ||
| "resetMocks": true, | ||
| "resetModules": true, | ||
| "coverageThreshold": { | ||
| "global": { | ||
| "statements": 100, | ||
| "branches": 100, | ||
| "functions": 100, | ||
| "lines": 100 | ||
| } | ||
| } | ||
| }, | ||
| "dependencies": { | ||
| "babel-generate-guard-clauses": "^2.0.0", | ||
| "babel-template": "^6.26.0", | ||
| "java-method-parser": "^0.4.5" | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why by type and not by id? Does it not work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UIPickerView have not accessibility ID, testID = {'CustomDatePicker'} need to be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a problem. If user has more than one pickers, the API will break
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UIPickerViewis aUIView, so it can have an accessibility ID. Are you seeing thatUIDatePickerdoes not forward that ID?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that UI element via AccessebilityInspector (from Xcode Instruments), and now I found only one way to get element by type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't work on android
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We know. We want to hone down iOS support first, then we will implement Android as well.