hotfix: added a retry on install (XCode 10 issue) #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what the repercussions of this are yet. I want to have a full picture first of why install fails, and I am unable to do so since I only reproduced the problem once. |
|
We can push it for now as a workaround. @noomorph Does this solve the VM issue you have? |
|
Accepting this as a workaround. We'll continue investigating in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #954
I suggest merging a hotfix given a blocker status of
appleSimUtils.install()with XCode 10.@LeoNatan , @rotemmiz , what do you think?
@guyca , can you check if it helps in your case, please?