Fix post-install script when project lives on a path with spaces #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found out that a project that lives under a path with spaces make the post-install script fail. Our CI checks the project under `~/Application Support/project` which makes the script throw an error. ``` > detox@8.2.3 postinstall /Users/bruno/Go Agent/mobile/node_modules/detox > node scripts/postinstall.js + xcodebuild -version +++ dirname /Users/bruno/Go Agent/mobile/node_modules/detox/scripts/build_framework.ios.sh usage: dirname path ++ dirname usage: dirname path + detoxRootPath= child_process.js:632 throw err; ^ Error: Command failed: /Users/bruno/Go Agent/mobile/node_modules/detox/scripts/build_framework.ios.sh ``` This is caused by the argument expansion on shell to think it is taking more arguments than it should. The strategy is to use quotes on shell scripts when refering to paths, such as `"$var"`. This commit wraps the variables refering to paths into quotes to avoid the argument split when expanding. Related to: - wix#824
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found out that a project that lives under a path with spaces make the
post-install script fail. Our CI checks the project under
~/Application Support/projectwhich makes the script throw an error.This is caused by the argument expansion on shell to think it is taking
more arguments than it should. The strategy is to use quotes on shell
scripts when refering to paths, such as
"$var".This commit wraps the variables refering to paths into quotes to avoid
the argument split when expanding.
Related to: