Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: read unexpected EOF error message in logs #966

Merged
merged 4 commits into from
Oct 3, 2018

Conversation

noomorph
Copy link
Collaborator

@noomorph noomorph commented Oct 3, 2018

Seeing lately errors like this:

detox[39596] ERROR: [exec.js/SPAWN_STDERR, #31] read: unexpected EOF!

Looks like a workaround for unsupported logcat -f option on older API levels did not work 100% correctly. So I think we could revert to the previous logic for API levels that support it.

  • verify on API levels 19-25

@noomorph noomorph requested a review from rotemmiz as a code owner October 3, 2018 06:24
@noomorph noomorph changed the title [wip] hotfix: read unexpected EOF error message in logs hotfix: read unexpected EOF error message in logs Oct 3, 2018
@noomorph noomorph merged commit fc247d6 into master Oct 3, 2018
@noomorph noomorph deleted the noomorph/partial-revert-logcat-changes branch October 3, 2018 17:49
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants