Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.4.2 iOS - completionHandler crash #746

Closed
iJimmyWei opened this issue Jun 17, 2021 · 0 comments · Fixed by #748
Closed

3.4.2 iOS - completionHandler crash #746

iJimmyWei opened this issue Jun 17, 2021 · 0 comments · Fixed by #748

Comments

@iJimmyWei
Copy link

Hi,

We recently upgraded from 3.1.2 to 3.4.2 on iOS and have been encountering this, it appears to be crashing when hitting the completionHandler

#2	0x00000001047291b0 in __39-[RNNotificationsStore completeAction:]_block_invoke at ../node_modules/react-native-notifications/lib/ios/RNNotificationsStore.m:50

Screenshot 2021-06-17 at 15 45 17

Crashes have been random, some users are reportedly crashing after 8 hours of usage, some only a few minutes. It seems random/sporadic and doesn't occur more than once for a user.

Has anyone else had something similar? - looks like it could be related to these changes #692
This was referenced Jun 20, 2021
Merged
Closed
yogevbd pushed a commit that referenced this issue Jun 23, 2021
@DanielEliraz
finish run completion handler in main thread (#748)
9a670a6 
Finishing #692 . As it said there, completion handler should run in main thread.
Should fix #746
@Vollkorn01 Vollkorn01 mentioned this issue Nov 24, 2021
Closed
@iotashan iotashan mentioned this issue Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

finish run completion handler in main thread wix/react-native-notifications
1 participant
@iJimmyWei