Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action completeHandler must run on main thread #692

Merged
merged 4 commits into from
Oct 28, 2020
Merged

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Oct 22, 2020

On iOS 14 built with Xcode 12 fixes a crash mentioning that completionHandler should run on the main thread

On iOS 14 built with Xcode 12 fixes a crash mentioning that completionHandler should run on the main thread
yogevbd
yogevbd previously approved these changes Oct 28, 2020
@yogevbd yogevbd merged commit d9433c7 into wix:master Oct 28, 2020
@yogevbd yogevbd added the bug label Oct 28, 2020
mburmistrov pushed a commit to mburmistrov/react-native-notifications that referenced this pull request Jan 10, 2021
On iOS 14 built with Xcode 12 fixes a crash mentioning that completionHandler should run on the main thread

Co-authored-by: yogevbd <yogev132@gmail.com>
yogevbd pushed a commit that referenced this pull request Jun 23, 2021
Finishing #692 . As it said there, completion handler should run in main thread.
Should fix #746
@ramirobg94
Copy link

Still same error:
In sentry appears like this

EXC_BREAKPOINT Exception 6, Code 2598399772, Subcode 8

completionHandler(presentationOptions);

Captura de pantalla 2022-03-31 a las 18 15 29
Captura de pantalla 2022-03-31 a las 18 15 42
Captura de pantalla 2022-03-31 a las 18 15 50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants