-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reuse_existing should check the interpreter #123
Comments
Interesting, wouldn't that change the name of the virtualenv folder? |
@theacodes I'm not 100% sure, but I think "not always" is the answer. |
Cool, makes sense for us to check it then. |
I'm not 100% how to do this yet. We don't ever know the full path to the interpreter, we just figure out enough info to get virtualenv to figure it out. I could try invoking the interpreter. |
Yes. You can get the actual interpreter via: original = session.run("python", "-c", "import sys; print(sys.real_prefix)", silent=True) |
Invoking the interpreter doesn't quite get me any closer. We could invoke our resolved interpreter and invoke the one in the virtualenv and compare. Still not 100% sure on that. |
Yes that's what you want to do. |
From #231, we should also test the type of environment. |
If
reuse_existing=True
when creating aVirtualenv
, but the interpreter has changed, then the environment should still be re-created.The text was updated successfully, but these errors were encountered: